Migrate ESLint to work with 9.x.x, fix code (#76)

Author: davidjgoss

.github/workflows/test-javascript.yml

@@ -39,4 +39,7 @@ jobs:
         working-directory: javascript
 
       - run: npm run build
+        working-directory: javascript
+
+      - run: npm run lint
         working-directory: javascript

javascript/.eslintrc.json

@@ -0,0 +1,72 @@
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+
+import { fixupConfigRules, fixupPluginRules } from '@eslint/compat'
+import { FlatCompat } from '@eslint/eslintrc'
+import js from '@eslint/js'
+import typescriptEslint from '@typescript-eslint/eslint-plugin'
+import tsParser from '@typescript-eslint/parser'
+import { defineConfig } from 'eslint/config'
+import _import from 'eslint-plugin-import'
+import n from 'eslint-plugin-n'
+import simpleImportSort from 'eslint-plugin-simple-import-sort'
+import globals from 'globals'
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = path.dirname(__filename)
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+})
+
+export default defineConfig([
+  {
+    extends: fixupConfigRules(
+      compat.extends(
+        'eslint:recommended',
+        'plugin:import/typescript',
+        'plugin:@typescript-eslint/eslint-recommended',
+        'plugin:@typescript-eslint/recommended',
+      )
+    ),
+
+    plugins: {
+      import: fixupPluginRules(_import),
+      'simple-import-sort': simpleImportSort,
+      n,
+      '@typescript-eslint': fixupPluginRules(typescriptEslint),
+    },
+
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+      },
+
+      parser: tsParser,
+      ecmaVersion: 5,
+      sourceType: 'module',
+
+      parserOptions: {
+        project: 'tsconfig.json',
+      },
+    },
+
+    rules: {
+      'import/no-cycle': 'error',
+      'n/no-extraneous-import': 'error',
+      '@typescript-eslint/ban-ts-ignore': 'off',
+      '@typescript-eslint/ban-ts-comment': 'off',
+      '@typescript-eslint/explicit-module-boundary-types': 'off',
+      '@typescript-eslint/explicit-function-return-type': 'off',
+      '@typescript-eslint/no-use-before-define': 'off',
+      '@typescript-eslint/interface-name-prefix': 'off',
+      '@typescript-eslint/member-delimiter-style': 'off',
+      '@typescript-eslint/no-explicit-any': 'error',
+      '@typescript-eslint/no-non-null-assertion': 'error',
+      'simple-import-sort/imports': 'error',
+      'simple-import-sort/exports': 'error',
+    },
+  },
+])

javascript/eslint.config.mjs

@@ -16,8 +16,8 @@
   "scripts": {
     "build": "tsc --build tsconfig.build.json",
     "clean": "rm -rf dist",
-    "lint-fix": "eslint --ext ts --max-warnings 0 --fix src && prettier --write src",
-    "lint": "eslint --ext ts --max-warnings 0 && prettier --check src",
+    "fix": "eslint --ext ts --max-warnings 0 src --fix src && prettier --write src",
+    "lint": "eslint --ext ts --max-warnings 0 src && prettier --check src",
     "test": "mocha 'src/**/*.spec.*'",
     "prepublishOnly": "tsc --build tsconfig.build.json"
   },
@@ -33,6 +33,9 @@
   "devDependencies": {
     "@cucumber/message-streams": "^4.0.1",
     "@cucumber/messages": "28.0.0",
+    "@eslint/compat": "^1.3.1",
+    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/js": "^9.31.0",
     "@types/chai": "^5.0.0",
     "@types/chai-almost": "^1.0.3",
     "@types/chai-xml": "^0.3.6",
@@ -45,11 +48,10 @@
     "chai-almost": "^1.0.1",
     "chai-xml": "^0.4.1",
     "eslint": "9.31.0",
-    "eslint-config-prettier": "10.1.5",
     "eslint-plugin-import": "2.32.0",
     "eslint-plugin-n": "17.21.0",
-    "eslint-plugin-prettier": "5.5.1",
     "eslint-plugin-simple-import-sort": "12.1.1",
+    "globals": "^16.3.0",
     "globby": "^14.0.2",
     "mocha": "^11.0.0",
     "prettier": "3.6.2",

javascript/package-lock.json

@@ -14,7 +14,7 @@ import formatter from './index.js'
 const asyncPipeline = util.promisify(pipeline)
 use(chaiXml)
 
-describe('Acceptance Tests', async function() {
+describe('Acceptance Tests', async function () {
   this.timeout(10_000)
 
   const ndjsonFiles = globbySync(`*.ndjson`, {
@@ -46,7 +46,7 @@ describe('Acceptance Tests', async function() {
             emit(envelope)
             callback()
           },
-        }),
+        })
       )
 
       const expectedXml = fs.readFileSync(ndjsonFile.replace('.ndjson', '.xml'), {