emit failure element

Author: davidjgoss

javascript/src/ExtendedQuery.ts

@@ -133,9 +133,7 @@ export class ExtendedQuery {
 
   findPickleBy(testCaseStarted: TestCaseStarted) {
     const testCase = this.findTestCaseBy(testCaseStarted)
-    if (!testCase) {
-      return undefined
-    }
+    assert.ok(testCase, 'Expected to find TestCase from TestCaseStarted')
     return this.pickleById.get(testCase.pickleId)
   }
 
@@ -167,6 +165,14 @@ export class ExtendedQuery {
     )
   }
 
+  findMostSevereTestStepResultBy(testCaseStarted: TestCaseStarted) {
+    return getWorstTestStepResult(
+      this.findTestStepFinishedAndTestStepBy(testCaseStarted).map(
+        ([testStepFinished]) => testStepFinished.testStepResult
+      )
+    )
+  }
+
   findTestStepBy(testStepFinished: TestStepFinished) {
     return this.testStepById.get(testStepFinished.testStepId)
   }

javascript/src/index.ts

@@ -1,7 +1,7 @@
 import * as assert from 'node:assert'
 
 import { Query as GherkinQuery } from '@cucumber/gherkin-utils'
-import { Envelope, TestStepResultStatus } from '@cucumber/messages'
+import { Envelope, TestCaseStarted, TestStepResultStatus } from '@cucumber/messages'
 import xmlbuilder from 'xmlbuilder'
 
 import { ExtendedQuery } from './ExtendedQuery.js'
@@ -35,12 +35,15 @@ export default {
         builder.att('errors', testSuite.errors)
 
         for (const testCase of testSuite.testCases) {
-          const element = builder.ele('testcase', {
+          const testcaseElement = builder.ele('testcase', {
             classname: testCase.classname,
             name: testCase.name,
             time: testCase.time,
           })
-          element.ele('system-out', {}).cdata(testCase.output)
+          if (testCase.failure) {
+            testcaseElement.ele(testCase.failure.type)
+          }
+          testcaseElement.ele('system-out', {}).cdata(testCase.output)
         }
 
         write(builder.end({ pretty: true }))
@@ -49,23 +52,28 @@ export default {
   },
 }
 
-interface Report {
+interface ReportSuite {
   time: number
   tests: number
   skipped: number
   failures: number
   errors: number
-  testCases: ReadonlyArray<TestCase>
+  testCases: ReadonlyArray<ReportTestCase>
 }
 
-interface TestCase {
+interface ReportTestCase {
   classname: string
   name: string
   time: number
+  failure?: ReportFailure
   output: string
 }
 
-function makeReport(query: ExtendedQuery): Report {
+interface ReportFailure {
+  type: 'failure' | 'skipped'
+}
+
+function makeReport(query: ExtendedQuery): ReportSuite {
   const statuses = query.countMostSevereTestStepResultStatus()
   return {
     time: durationToSeconds(query.findTestRunDuration()),
@@ -80,14 +88,15 @@ function makeReport(query: ExtendedQuery): Report {
   }
 }
 
-function makeTestCases(query: ExtendedQuery): ReadonlyArray<TestCase> {
+function makeTestCases(query: ExtendedQuery): ReadonlyArray<ReportTestCase> {
   return query.findAllTestCaseStarted().map((testCaseStarted) => {
     const pickle = query.findPickleBy(testCaseStarted)
     assert.ok(pickle, 'Expected to find Pickle by TestCaseStarted')
     return {
       classname: pickle.uri,
       name: pickle.name,
       time: durationToSeconds(query.findTestCaseDurationBy(testCaseStarted)),
+      failure: makeFailure(query, testCaseStarted),
       output: query
         .findTestStepFinishedAndTestStepBy(testCaseStarted)
         // filter out hooks
@@ -103,3 +112,16 @@ function makeTestCases(query: ExtendedQuery): ReadonlyArray<TestCase> {
     }
   })
 }
+
+function makeFailure(
+  query: ExtendedQuery,
+  testCaseStarted: TestCaseStarted
+): ReportFailure | undefined {
+  const result = query.findMostSevereTestStepResultBy(testCaseStarted)
+  if (result.status === TestStepResultStatus.PASSED) {
+    return undefined
+  }
+  return {
+    type: result.status === TestStepResultStatus.SKIPPED ? 'skipped' : 'failure',
+  }
+}