Reduce noise from tests

Author: mpkorstanje

java/src/main/java/io/cucumber/messages/cli/HtmlCommand.java

@@ -1,7 +1,6 @@
 package io.cucumber.messages.cli;
 
 import io.cucumber.htmlformatter.MessagesToHtmlWriter;
-import io.cucumber.jsonformatter.MessagesToJsonWriter;
 import io.cucumber.messages.NdjsonToMessageIterable;
 import picocli.CommandLine.Command;
 import picocli.CommandLine.Model.CommandSpec;
@@ -52,7 +51,8 @@ public Integer call() throws IOException {
         var options = new CommonOptions(spec, source, output, HtmlCommand::html);
 
         try (var envelopes = new NdjsonToMessageIterable(options.sourceInputStream(), Jackson.deserializer());
-             var writer = MessagesToHtmlWriter.builder(Jackson.OBJECT_MAPPER::writeValue).build(options.outputPrintWriter())
+             var writer = MessagesToHtmlWriter.builder(Jackson.OBJECT_MAPPER::writeValue)
+                     .build(options.outputPrintWriter())
         ) {
             for (var envelope : envelopes) {
                 writer.write(envelope);

java/src/test/java/io/cucumber/messages/cli/CucumberHtmlCommandTest.java

@@ -16,7 +16,6 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
-import static java.nio.charset.StandardCharsets.UTF_8;
 import static java.nio.file.Files.newInputStream;
 import static java.nio.file.Files.readString;
 import static org.assertj.core.api.Assertions.assertThat;
@@ -49,9 +48,6 @@ void setup() {
     void cleanup() {
         System.setIn(originalSystemIn);
         System.setOut(originalSystemOut);
-        // Helps with debugging
-        System.out.println(stdOut.toString(UTF_8));
-        System.out.println(stdErr);
     }
 
     @Test

java/src/test/java/io/cucumber/messages/cli/CucumberJsonCommandTest.java

@@ -16,7 +16,6 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
-import static java.nio.charset.StandardCharsets.UTF_8;
 import static java.nio.file.Files.newInputStream;
 import static java.nio.file.Files.readString;
 import static org.assertj.core.api.Assertions.assertThat;
@@ -50,9 +49,6 @@ void setup() {
     void cleanup() {
         System.setIn(originalSystemIn);
         System.setOut(originalSystemOut);
-        // Helps with debugging
-        System.out.println(stdOut.toString(UTF_8));
-        System.out.println(stdErr);
     }
 
     @Test

java/src/test/java/io/cucumber/messages/cli/JunitXmlCommandTest.java

@@ -16,7 +16,6 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
-import static java.nio.charset.StandardCharsets.UTF_8;
 import static java.nio.file.Files.newInputStream;
 import static java.nio.file.Files.readString;
 import static org.assertj.core.api.Assertions.assertThat;
@@ -50,9 +49,6 @@ void setup() {
     void cleanup() {
         System.setIn(originalSystemIn);
         System.setOut(originalSystemOut);
-        // Helps with debugging
-        System.out.println(stdOut.toString(UTF_8));
-        System.out.println(stdErr);
     }
 
     @Test

java/src/test/java/io/cucumber/messages/cli/MessagesCliTest.java

@@ -1,11 +1,9 @@
 package io.cucumber.messages.cli;
 
-import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import picocli.CommandLine;
 
-import java.io.PrintStream;
 import java.io.PrintWriter;
 import java.io.StringWriter;
 import java.util.regex.Pattern;
@@ -18,7 +16,6 @@ class MessagesCliTest {
     final StringWriter out = new StringWriter();
     final StringWriter err = new StringWriter();
     final CommandLine cmd = MessagesCli.createCommandLine();
-    PrintStream originalSystemOut;
 
 
     @BeforeEach
@@ -27,15 +24,6 @@ void setup() {
         cmd.setOut(new PrintWriter(out));
     }
 
-    @AfterEach
-    void cleanup() {
-        // Helps with debugging
-        System.out.println("Contents of out:");
-        System.out.println(out);
-        System.out.println("Contents of err:");
-        System.out.println(err);
-    }
-
     @Test
     void help() {
         int exitCode = cmd.execute("--help");

java/src/test/java/io/cucumber/messages/cli/TestngXmlCommandTest.java

@@ -16,7 +16,6 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
-import static java.nio.charset.StandardCharsets.UTF_8;
 import static java.nio.file.Files.newInputStream;
 import static java.nio.file.Files.readString;
 import static org.assertj.core.api.Assertions.assertThat;
@@ -50,9 +49,6 @@ void setup() {
     void cleanup() {
         System.setIn(originalSystemIn);
         System.setOut(originalSystemOut);
-        // Helps with debugging
-        System.out.println(stdOut.toString(UTF_8));
-        System.out.println(stdErr);
     }
 
     @Test