Skip to content

Commit 34d41b2

Browse files
authored
Remove duplicate code for python from codegen (#309)
1 parent d68f45f commit 34d41b2

File tree

1 file changed

+4
-24
lines changed

1 file changed

+4
-24
lines changed

codegen/generators/python.rb

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,11 @@ def get_property_type(parent_type_name, property_name, property)
4040

4141
def array_type_for(type_name)
4242
inner_type = if language_translations_for_data_types.values.include?(type_name)
43-
type_name # Keep primitive types as is
43+
# Keep primitive types as is
44+
"list[#{type_name}]"
4445
else
45-
class_name(type_name) # CamelCase for complex types
46+
# CamelCase for complex types
47+
"list[#{class_name(type_name)}]"
4648
end
4749
inner_type
4850
end
@@ -97,28 +99,6 @@ def default_value_for_string(parent_type_name, property_name, property)
9799
end
98100
end
99101

100-
def type_for(parent_type_name, property_name, property)
101-
if property['$ref']
102-
property_type_from_ref(property['$ref'])
103-
elsif property['type']
104-
property_type_from_type(parent_type_name, property_name, property, type: property['type'])
105-
else
106-
raise "Property #{property_name} did not define 'type' or '$ref'"
107-
end
108-
end
109-
110-
def property_type_from_type(parent_type_name, property_name, property, type:)
111-
if type == 'array'
112-
type = type_for(parent_type_name, nil, property['items'])
113-
inner_type = array_type_for(type)
114-
"list[#{inner_type}]"
115-
elsif property['enum']
116-
enum_name(parent_type_name, property_name, property['enum'])
117-
else
118-
language_translations_for_data_types.fetch(type)
119-
end
120-
end
121-
122102
def enum_constant(value)
123103
value.gsub(/[.\/+]/, '_').downcase
124104
end

0 commit comments

Comments
 (0)