-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
β‘ enhancementRequest for new functionalityRequest for new functionality
Milestone
Description
π€ What's the problem you're trying to solve?
While converting the plugins to use messages I'm running into some annoyances using the messages API.
β¨ What's your proposed solution?
- Timestamp should use
Timestamp(Long seconds, Integer nanos)
to matchInstants.getEpochSecond
andgetNano
. - Location should use
Location(Integer line, Integer column)
. There are no instances were a string in Java can be addressed with a long. - Same for
Group(List<Group> children, Integer start, String value)
Implementing Comparators
for Location
and Timestamp
could also help avoid some annoyances. (e.g. https://github.com/cucumber/query/blob/main/java/src/main/java/io/cucumber/query/TimestampComparator.java).
β Have you considered any alternatives or workarounds?
No response
π Any additional context?
No response
Metadata
Metadata
Assignees
Labels
β‘ enhancementRequest for new functionalityRequest for new functionality