Add findLineageBy TestCaseFinished (#123)

mpkorstanje · web-flow · commit 48a018a1b2f8 · 2025-10-27T16:09:28.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
+- Add `findLineageBy(TestCaseFinished)` ([#119](https://github.com/cucumber/query/pull/119))
 
 ## [14.5.0] - 2025-10-08
 ### Added
diff --git a/java/src/main/java/io/cucumber/query/Query.java b/java/src/main/java/io/cucumber/query/Query.java
@@ -458,4 +458,9 @@ public Optional<Lineage> findLineageBy(TestCaseStarted testCaseStarted) {
         return findPickleBy(testCaseStarted)
                 .flatMap(this::findLineageBy);
     }
+
+    public Optional<Lineage> findLineageBy(TestCaseFinished testCaseFinished) {
+        return findPickleBy(testCaseFinished)
+                .flatMap(this::findLineageBy);
+    }
 }
diff --git a/java/src/test/java/io/cucumber/query/QueryAcceptanceTest.java b/java/src/test/java/io/cucumber/query/QueryAcceptanceTest.java
@@ -182,6 +182,12 @@ static Map<String, Function<Query, Object>> createQueries() {
                     .map(Optional::get)
                     .map(namingStrategy::reduce)
                     .collect(toList()));
+            results.put("testCaseFinished", query.findAllTestCaseFinished().stream()
+                    .map(query::findLineageBy)
+                    .filter(Optional::isPresent)
+                    .map(Optional::get)
+                    .map(namingStrategy::reduce)
+                    .collect(toList()));
             results.put("pickle", query.findAllPickles().stream()
                     .map(query::findLineageBy)
                     .filter(Optional::isPresent)
diff --git a/javascript/src/Query.ts b/javascript/src/Query.ts
@@ -728,8 +728,8 @@ export default class Query {
       })
   }
 
-  public findLineageBy(element: Pickle | TestCaseStarted): Lineage | undefined {
-    const pickle = 'testCaseId' in element ? this.findPickleBy(element) : element
+  public findLineageBy(element: Pickle | TestCaseStarted | TestCaseFinished): Lineage | undefined {
+    const pickle = 'astNodeIds' in element ? element : this.findPickleBy(element)
     const deepestAstNodeId = pickle.astNodeIds.at(-1)
     assert.ok(deepestAstNodeId, 'Expected Pickle to have at least one astNodeId')
     return this.lineageById.get(deepestAstNodeId)
diff --git a/javascript/src/acceptance.spec.ts b/javascript/src/acceptance.spec.ts
@@ -107,6 +107,7 @@ describe('Acceptance Tests', async () => {
     },
     findLocationOf: (query: Query) =>
       query.findAllPickles().map((pickle) => query.findLocationOf(pickle)),
+
     findPickleBy: (query: Query) => {
       return {
         testCaseStarted: query
diff --git a/testdata/src/attachments.findLineageBy.results.json b/testdata/src/attachments.findLineageBy.results.json
@@ -8,6 +8,15 @@
     "Attachments - Attaching PDFs with a different filename",
     "Attachments - Attaching URIs"
   ],
+  "testCaseFinished" : [
+    "Attachments - Strings can be attached with a media type",
+    "Attachments - Log text",
+    "Attachments - Log ANSI coloured text",
+    "Attachments - Log JSON",
+    "Attachments - Byte arrays are base64-encoded regardless of media type",
+    "Attachments - Attaching PDFs with a different filename",
+    "Attachments - Attaching URIs"
+  ],
   "pickle" : [
     "Attachments - Strings can be attached with a media type",
     "Attachments - Log text",
diff --git a/testdata/src/empty.findLineageBy.results.json b/testdata/src/empty.findLineageBy.results.json
@@ -2,6 +2,9 @@
   "testCaseStarted" : [
     "Empty Scenarios - Blank Scenario"
   ],
+  "testCaseFinished" : [
+    "Empty Scenarios - Blank Scenario"
+  ],
   "pickle" : [
     "Empty Scenarios - Blank Scenario"
   ]
diff --git a/testdata/src/examples-tables.findLineageBy.results.json b/testdata/src/examples-tables.findLineageBy.results.json
@@ -8,6 +8,15 @@
     "Examples Tables - Eating cucumbers with <friends> friends - #1.2",
     "Examples Tables - Eating cucumbers with <friends> friends - #1.3"
   ],
+  "testCaseFinished" : [
+    "Examples Tables - Eating cucumbers - These are passing - #1.1",
+    "Examples Tables - Eating cucumbers - These are passing - #1.2",
+    "Examples Tables - Eating cucumbers - These are failing - #2.1",
+    "Examples Tables - Eating cucumbers - These are failing - #2.2",
+    "Examples Tables - Eating cucumbers with <friends> friends - #1.1",
+    "Examples Tables - Eating cucumbers with <friends> friends - #1.2",
+    "Examples Tables - Eating cucumbers with <friends> friends - #1.3"
+  ],
   "pickle" : [
     "Examples Tables - Eating cucumbers - These are passing - #1.1",
     "Examples Tables - Eating cucumbers - These are passing - #1.2",
diff --git a/testdata/src/global-hooks-attachments.findLineageBy.results.json b/testdata/src/global-hooks-attachments.findLineageBy.results.json
@@ -2,6 +2,9 @@
   "testCaseStarted" : [
     "Global hooks with attachments - A scenario"
   ],
+  "testCaseFinished" : [
+    "Global hooks with attachments - A scenario"
+  ],
   "pickle" : [
     "Global hooks with attachments - A scenario"
   ]
diff --git a/testdata/src/global-hooks.findLineageBy.results.json b/testdata/src/global-hooks.findLineageBy.results.json
@@ -3,6 +3,10 @@
     "Global hooks - A passing scenario",
     "Global hooks - A failing scenario"
   ],
+  "testCaseFinished" : [
+    "Global hooks - A passing scenario",
+    "Global hooks - A failing scenario"
+  ],
   "pickle" : [
     "Global hooks - A passing scenario",
     "Global hooks - A failing scenario"
diff --git a/testdata/src/hooks.findLineageBy.results.json b/testdata/src/hooks.findLineageBy.results.json
@@ -3,6 +3,10 @@
     "Hooks - No tags and a passed step",
     "Hooks - No tags and a failed step"
   ],
+  "testCaseFinished" : [
+    "Hooks - No tags and a passed step",
+    "Hooks - No tags and a failed step"
+  ],
   "pickle" : [
     "Hooks - No tags and a passed step",
     "Hooks - No tags and a failed step"
diff --git a/testdata/src/minimal.findLineageBy.results.json b/testdata/src/minimal.findLineageBy.results.json
@@ -2,6 +2,9 @@
   "testCaseStarted" : [
     "minimal - cukes"
   ],
+  "testCaseFinished" : [
+    "minimal - cukes"
+  ],
   "pickle" : [
     "minimal - cukes"
   ]
diff --git a/testdata/src/rules.findLineageBy.results.json b/testdata/src/rules.findLineageBy.results.json
@@ -4,6 +4,11 @@
     "Usage of a `Rule` - A sale cannot happen if the customer does not have enough money - Enough money",
     "Usage of a `Rule` - a sale cannot happen if there is no stock - No chocolates left"
   ],
+  "testCaseFinished" : [
+    "Usage of a `Rule` - A sale cannot happen if the customer does not have enough money - Not enough money",
+    "Usage of a `Rule` - A sale cannot happen if the customer does not have enough money - Enough money",
+    "Usage of a `Rule` - a sale cannot happen if there is no stock - No chocolates left"
+  ],
   "pickle" : [
     "Usage of a `Rule` - A sale cannot happen if the customer does not have enough money - Not enough money",
     "Usage of a `Rule` - A sale cannot happen if the customer does not have enough money - Enough money",
diff --git a/testdata/src/unknown-parameter-type.findLineageBy.results.json b/testdata/src/unknown-parameter-type.findLineageBy.results.json
@@ -2,6 +2,9 @@
   "testCaseStarted" : [
     "Parameter Types - undefined parameter type"
   ],
+  "testCaseFinished" : [
+    "Parameter Types - undefined parameter type"
+  ],
   "pickle" : [
     "Parameter Types - undefined parameter type"
   ]

Original file line number	Diff line number	Diff line change
`@@ -458,4 +458,9 @@ public Optional<Lineage> findLineageBy(TestCaseStarted testCaseStarted) {`
`458`	`458`	`return findPickleBy(testCaseStarted)`
`459`	`459`	`.flatMap(this::findLineageBy);`
`460`	`460`	`}`
	`461`	`+`
	`462`	`+ public Optional<Lineage> findLineageBy(TestCaseFinished testCaseFinished) {`
	`463`	`+ return findPickleBy(testCaseFinished)`
	`464`	`+ .flatMap(this::findLineageBy);`
	`465`	`+ }`
`461`	`466`	`}`