Skip to content

Commit 2866212

Browse files
authored
upgrade to react 18, storybook -> ladle (#279)
* install react 18 and update peer deps * more dependency changes * fix compilation due to FunctionComponent changes * make test interactions async * fix test providers * build storybook as part of pr workflow * remove storybook * add ladle * add vite config to get around lunr issue * add ladle build to pr workflow * update stories to use ladle imports * remove atob workaround * remove redundant story * move stories inline with components * update readme * fix dependencies from bad merge * bump ladle version * dont run ladle build for now * fix lockfile * fix typescript issues * fix lint * Update README.md * Update CHANGELOG.md
1 parent c5d8c1e commit 2866212

33 files changed

+11500
-36808
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,5 @@ jobs:
2727
- run: npm test
2828
- run: npm run eslint
2929
- run: npm run compile
30+
# not running ladle build due to elasticlunr bundling issue
31+
# - run: npm run build

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1+
acceptance/
2+
build/
13
dist/
24
.idea/
35
node_modules/
46
*.log
57
.codegen
6-
acceptance/
7-
storybook-static
88
*.iml
99
.vscode-test

.storybook/main.js

Lines changed: 0 additions & 32 deletions
This file was deleted.

.storybook/preview.js

Lines changed: 0 additions & 4 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
66
and this project adheres to [Semantic Versioning](http://semver.org/).
77

88
## [Unreleased]
9+
### Changed
10+
- BREAKING CHANGE: React 18+ is now required ([#279](https://github.com/cucumber/react-components/pull/279))
911

1012
## [20.2.0] - 2022-09-13
1113
### Changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88

99
## Usage
1010

11+
React 18 or above is required.
12+
1113
The source code for screenshots above is:
1214

1315
```jsx
@@ -152,7 +154,7 @@ Run tests
152154

153155
Interactive development
154156

155-
npm run storybook
157+
npm start
156158

157159
## Ideas
158160

0 commit comments

Comments
 (0)