update types for react and react-dom (#328)

davidjgoss · web-flow · commit 7105a40b404c · 2022-12-17T16:32:54.000Z
* chore: update dependencies

* fix: status icon typing

* fix: update test wrapper
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -66,8 +66,8 @@
     "@types/jest": "^29.0.0",
     "@types/jsdom": "20.0.1",
     "@types/node": "18.11.16",
-    "@types/react": "17.0.52",
-    "@types/react-dom": "17.0.18",
+    "@types/react": "^18.0.26",
+    "@types/react-dom": "^18.0.9",
     "@typescript-eslint/eslint-plugin": "5.46.1",
     "@typescript-eslint/parser": "5.46.1",
     "core-js": "3.26.1",
diff --git a/src/components/gherkin/StatusIcon.tsx b/src/components/gherkin/StatusIcon.tsx
@@ -39,7 +39,7 @@ export const StatusIcon: FunctionComponent<StatusIconProps> = (props) => {
     defaultStyles,
     DefaultRenderer
   )
-  return <Customised {...props}>{props.children}</Customised>
+  return <Customised {...props} />
 }
 
 const statusIcon = (status: messages.TestStepResultStatus): IconDefinition => {
diff --git a/test-utils/index.tsx b/test-utils/index.tsx
@@ -29,7 +29,7 @@ const AllTheProviders: FunctionComponent<PropsWithChildren<{ options: TestRender
 }
 
 const customRender = (ui: ReactElement, options: Partial<TestRenderOptions> = {}) => {
-  const WrappedWithOptions: FunctionComponent = ({ children }) => (
+  const WrappedWithOptions: FunctionComponent<PropsWithChildren> = ({ children }) => (
     <AllTheProviders options={options}>{children}</AllTheProviders>
   )
   return render(ui, { wrapper: WrappedWithOptions })

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ export const StatusIcon: FunctionComponent<StatusIconProps> = (props) => {`
`39`	`39`	`defaultStyles,`
`40`	`40`	`DefaultRenderer`
`41`	`41`	`)`
`42`		`- return <Customised {...props}>{props.children}</Customised>`
	`42`	`+ return <Customised {...props} />`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`const statusIcon = (status: messages.TestStepResultStatus): IconDefinition => {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ const AllTheProviders: FunctionComponent<PropsWithChildren<{ options: TestRender`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`const customRender = (ui: ReactElement, options: Partial<TestRenderOptions> = {}) => {`
`32`		`- const WrappedWithOptions: FunctionComponent = ({ children }) => (`
	`32`	`+ const WrappedWithOptions: FunctionComponent<PropsWithChildren> = ({ children }) => (`
`33`	`33`	`<AllTheProviders options={options}>{children}</AllTheProviders>`
`34`	`34`	`)`
`35`	`35`	`return render(ui, { wrapper: WrappedWithOptions })`