Skip to content

Commit 5645cae

Browse files
authored
Merge pull request #22 from holger-zeit/fix-sqs-required-region-name
fix sqs required region name
2 parents f7e46f6 + 9b226ec commit 5645cae

File tree

2 files changed

+19
-13
lines changed

2 files changed

+19
-13
lines changed

eb_sqs/aws/sqs_queue_client.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from __future__ import absolute_import, unicode_literals
22

33
import boto3
4+
from botocore.config import Config
45
from botocore.exceptions import ClientError
56

67
from eb_sqs import settings
@@ -10,7 +11,10 @@
1011
class SqsQueueClient(QueueClient):
1112
def __init__(self):
1213
# type: () -> None
13-
self.sqs = boto3.resource('sqs')
14+
self.sqs = boto3.resource('sqs',
15+
region_name=settings.AWS_REGION,
16+
config=Config(retries={'max_attempts': settings.AWS_MAX_RETRIES})
17+
)
1418
self.queue_cache = {}
1519

1620
def _get_queue(self, queue_name):

eb_sqs/tests/aws/tests_aws_queue_client.py

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
from __future__ import absolute_import, unicode_literals
22

3-
from unittest import TestCase
3+
import time
4+
from unittest import TestCase, skip
45

56
import boto3
6-
import time
77
from moto import mock_sqs
88

9+
from eb_sqs import settings
910
from eb_sqs.aws.sqs_queue_client import SqsQueueClient
11+
from eb_sqs.worker.queue_client import QueueDoesNotExistException
1012

1113

1214
class AwsQueueClientTest(TestCase):
@@ -34,17 +36,17 @@ def test_add_message_delayed(self):
3436
queue.reload()
3537
self.assertEqual(queue.attributes["ApproximateNumberOfMessages"], '0')
3638

37-
time.sleep(delay+0.1)
39+
time.sleep(delay + 0.1)
3840

3941
queue.reload()
4042
self.assertEqual(queue.attributes["ApproximateNumberOfMessages"], '1')
4143

42-
# Disabled because current mock_sqs doesn't support invalid queue call
43-
#@mock_sqs()
44-
#def test_add_message_wrong_queue(self):
45-
# sqs = boto3.resource('sqs')
46-
# queue = sqs.create_queue(QueueName='default')
47-
# queue_client = SqsQueueClient()
48-
#
49-
# with self.assertRaises(QueueDoesNotExistException):
50-
# queue_client.add_message('invalid', 'msg', 0)
44+
@skip("Disabled because current mock_sqs doesn't support invalid queue call")
45+
@mock_sqs()
46+
def test_add_message_wrong_queue(self):
47+
sqs = boto3.resource('sqs')
48+
queue = sqs.create_queue(QueueName='default')
49+
queue_client = SqsQueueClient()
50+
51+
with self.assertRaises(QueueDoesNotExistException):
52+
queue_client.add_message('invalid', 'msg', 0)

0 commit comments

Comments
 (0)