Skip to content

Commit 889f9f6

Browse files
author
Alexey Tsitkin
committed
bulk delete
1 parent 9fd95be commit 889f9f6

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

eb_sqs/worker/service.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,17 @@ def process_messages(self, queues, worker):
6666
messages = self.poll_messages(queue)
6767
logger.debug('[django-eb-sqs] Polled {} messages'.format(len(messages)))
6868

69+
msg_entries = []
70+
6971
for msg in messages:
7072
self.process_message(msg, worker)
73+
msg_entries.append({
74+
'Id': msg.message_id,
75+
'ReceiptHandle': msg.receipt_handle
76+
})
77+
78+
queue.delete_messages(Entries=msg_entries)
79+
logger.debug('[django-eb-sqs] Deleted {} messages'.format(len(messages)))
7180
except Exception as exc:
7281
logger.warning('[django-eb-sqs] Error polling queue {}: {}'.format(queue.url, exc), exc_info=1)
7382

@@ -86,9 +95,6 @@ def process_message(self, msg, worker):
8695
logger.debug('[django-eb-sqs] Processed message {}'.format(msg.message_id))
8796
except Exception as exc:
8897
logger.error('[django-eb-sqs] Unhandled error: {}'.format(exc), exc_info=1)
89-
finally:
90-
msg.delete()
91-
logger.debug('[django-eb-sqs] Deleted message {}'.format(msg.message_id))
9298

9399
def get_queues_by_names(self, sqs, queue_names):
94100
# type: (ServiceResource, list) -> list

0 commit comments

Comments
 (0)