Skip to content

Commit 8dae7a3

Browse files
author
Alexey Tsitkin
committed
minor refactoring
1 parent abfe79c commit 8dae7a3

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

eb_sqs/worker/service.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,21 @@ def process_messages(self, queues, worker):
7575
'ReceiptHandle': msg.receipt_handle
7676
})
7777

78-
if len(messages) > 0:
79-
response = queue.delete_messages(Entries=msg_entries)
80-
logger.debug('[django-eb-sqs] Deleted {} messages successfully'.format(
81-
len(response.get('Successful', []))
82-
))
83-
logger.debug('[django-eb-sqs] Failed deleting {} messages'.format(
84-
len(response.get('Failed', []))
85-
))
78+
self.delete_messages(queue, msg_entries)
8679
except Exception as exc:
8780
logger.warning('[django-eb-sqs] Error polling queue {}: {}'.format(queue.url, exc), exc_info=1)
8881

82+
def delete_messages(self, queue, msg_entries):
83+
# type: (Queue, list) -> None
84+
if len(msg_entries) > 0:
85+
response = queue.delete_messages(Entries=msg_entries)
86+
logger.debug('[django-eb-sqs] Deleted {} messages successfully'.format(
87+
len(response.get('Successful', []))
88+
))
89+
logger.debug('[django-eb-sqs] Failed deleting {} messages'.format(
90+
len(response.get('Failed', []))
91+
))
92+
8993
def poll_messages(self, queue):
9094
# type: (Queue) -> list
9195
return queue.receive_messages(

0 commit comments

Comments
 (0)