Skip to content

Commit fd8aa3d

Browse files
committed
removed max_position_embeddings from computing generate_prepared_ds_path
1 parent 74df7e8 commit fd8aa3d

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/cehrbert/runners/runner_util.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ def generate_prepared_ds_path(data_args, model_args, data_folder=None) -> Path:
159159
- split_by_patient (bool): A flag indicating if the dataset should be split by patient IDs.
160160
- chronological_split (bool): A flag indicating if the split should be chronological.
161161
model_args (ModelArguments): An object containing model-specific arguments, such as:
162-
- max_position_embeddings (int): The maximum sequence length that the model supports.
163162
- tokenizer_name_or_path (str): The path or name of the tokenizer used for preprocessing.
164163
data_folder (str, optional): An optional folder path to override the `data_folder` from `data_args`.
165164
@@ -179,7 +178,6 @@ def generate_prepared_ds_path(data_args, model_args, data_folder=None) -> Path:
179178
180179
Note:
181180
The hash is generated from a combination of the following:
182-
- model_args.max_position_embeddings
183181
- paths of `data_folder` and `model_args.tokenizer_name_or_path`
184182
- `data_args.validation_split_percentage` (if provided)
185183
- `data_args.test_eval_ratio`, `data_args.split_by_patient`, and `data_args.chronological_split`
@@ -188,9 +186,7 @@ def generate_prepared_ds_path(data_args, model_args, data_folder=None) -> Path:
188186
"""
189187
data_folder = data_folder if data_folder else data_args.data_folder
190188
concatenated_str = (
191-
str(model_args.max_position_embeddings)
192-
+ "|"
193-
+ os.path.expanduser(data_folder)
189+
os.path.expanduser(data_folder)
194190
+ "|"
195191
+ os.path.expanduser(model_args.tokenizer_name_or_path)
196192
+ "|"

0 commit comments

Comments
 (0)