Skip to content

Commit 1af8e85

Browse files
committed
Initial review notes: improve tests, few new tests
1 parent ee6dbf5 commit 1af8e85

File tree

5 files changed

+73
-4
lines changed

5 files changed

+73
-4
lines changed

packages/cursorless-engine/languages/perl.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,5 +131,3 @@ export function stringTextFragmentExtractor(
131131

132132
return null;
133133
}
134-
135-
// EOF

packages/cursorless-vscode-e2e/suite/fixtures/recorded/languages/perl/changeArg.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ initialState:
1616
active: {line: 0, character: 36}
1717
marks: {}
1818
finalState:
19-
documentContents: some_funky_func( )
19+
documentContents: some_funky_func( "three", "args" )
2020
selections:
2121
- anchor: {line: 0, character: 17}
2222
active: {line: 0, character: 17}

packages/cursorless-vscode-e2e/suite/fixtures/recorded/languages/perl/changeItem.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ initialState:
2222
finalState:
2323
documentContents: |-
2424
%hash = (
25-
one => ,
25+
,
2626
two => 2,
2727
);
2828
selections:
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
languageId: perl
2+
command:
3+
version: 4
4+
spokenForm: chuck item
5+
action: {name: remove}
6+
targets:
7+
- type: primitive
8+
modifiers:
9+
- type: containingScope
10+
scopeType: {type: collectionItem}
11+
usePrePhraseSnapshot: true
12+
initialState:
13+
documentContents: |-
14+
%hash = (
15+
one => 1,
16+
two => 2,
17+
);
18+
selections:
19+
- anchor: {line: 2, character: 4}
20+
active: {line: 2, character: 4}
21+
marks: {}
22+
finalState:
23+
documentContents: |-
24+
%hash = (
25+
two => 2,
26+
);
27+
selections:
28+
- anchor: {line: 2, character: 4}
29+
active: {line: 2, character: 4}
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
languageId: perl
2+
command:
3+
version: 4
4+
spokenForm: chuck round
5+
action: {name: remove}
6+
targets:
7+
- type: primitive
8+
modifiers:
9+
- type: containingScope
10+
scopeType: {type: surroundingPair, delimiter: parentheses}
11+
usePrePhraseSnapshot: true
12+
initialState:
13+
documentContents: |-
14+
"aaa (bbb) ccc"
15+
'aaa (bbb) ccc'
16+
q(aaa (bbb) ccc)
17+
qq(aaa (bbb) ccc)
18+
selections:
19+
- anchor: {line: 0, character: 7}
20+
active: {line: 0, character: 7}
21+
- anchor: {line: 1, character: 7}
22+
active: {line: 1, character: 7}
23+
- anchor: {line: 2, character: 8}
24+
active: {line: 2, character: 8}
25+
- anchor: {line: 3, character: 9}
26+
active: {line: 3, character: 9}
27+
marks: {}
28+
finalState:
29+
documentContents: |-
30+
"aaa ccc"
31+
'aaa ccc'
32+
q(aaa ccc)
33+
qq(aaa ccc)
34+
selections:
35+
- anchor: {line: 0, character: 5}
36+
active: {line: 0, character: 5}
37+
- anchor: {line: 1, character: 5}
38+
active: {line: 1, character: 5}
39+
- anchor: {line: 2, character: 6}
40+
active: {line: 2, character: 6}
41+
- anchor: {line: 3, character: 7}
42+
active: {line: 3, character: 7}

0 commit comments

Comments
 (0)