head/tail are bounded by all interiors not just pair (#3070)

Today if you don't specify a scope after head/tail we default to the
line bounded by optional surrounding pair interior. This change makes it
so we use any interior. I gotten really used to head/tail being bounded
by interior, but lately I've been doing a lot of jsx and I keep trying
to use head and tail inside of a jsx element and accidentally removing
half the line.

Author: AndreasArvidsson

data/fixtures/recorded/modifiers/interior/changeHead.yml

@@ -0,0 +1,22 @@
+languageId: typescriptreact
+command:
+  version: 7
+  spokenForm: change head
+  action:
+    name: clearAndSetSelection
+    target:
+      type: primitive
+      modifiers:
+        - {type: extendThroughStartOf}
+  usePrePhraseSnapshot: false
+initialState:
+  documentContents: <div>abcd</div>
+  selections:
+    - anchor: {line: 0, character: 7}
+      active: {line: 0, character: 7}
+  marks: {}
+finalState:
+  documentContents: <div>cd</div>
+  selections:
+    - anchor: {line: 0, character: 5}
+      active: {line: 0, character: 5}

data/fixtures/recorded/modifiers/interior/changeTail.yml

@@ -0,0 +1,22 @@
+languageId: typescriptreact
+command:
+  version: 7
+  spokenForm: change tail
+  action:
+    name: clearAndSetSelection
+    target:
+      type: primitive
+      modifiers:
+        - {type: extendThroughEndOf}
+  usePrePhraseSnapshot: false
+initialState:
+  documentContents: <div>abcd</div>
+  selections:
+    - anchor: {line: 0, character: 7}
+      active: {line: 0, character: 7}
+  marks: {}
+finalState:
+  documentContents: <div>ab</div>
+  selections:
+    - anchor: {line: 0, character: 7}
+      active: {line: 0, character: 7}

packages/cursorless-engine/src/processTargets/modifiers/HeadTailStage.ts

@@ -74,11 +74,11 @@ class BoundedLineStage implements ModifierStage {
 
   run(target: Target, options: ModifierStateOptions): Target[] {
     const line = this.getContainingLine(target, options);
-    const pairInterior = this.getContainingPairInterior(target, options);
+    const interior = this.getContainingInterior(target, options);
 
     const intersection =
-      pairInterior != null
-        ? line.contentRange.intersection(pairInterior.contentRange)
+      interior != null
+        ? line.contentRange.intersection(interior.contentRange)
         : null;
 
     if (intersection == null || intersection.isEmpty) {
@@ -94,15 +94,14 @@ class BoundedLineStage implements ModifierStage {
     ];
   }
 
-  private getContainingPairInterior(
+  private getContainingInterior(
     target: Target,
     options: ModifierStateOptions,
   ): Target | undefined {
     try {
       return this.getContaining(target, options, {
-        type: "surroundingPairInterior",
-        delimiter: "any",
-      })[0];
+        type: "interior",
+      });
     } catch (error) {
       if (error instanceof NoContainingScopeError) {
         return undefined;
@@ -117,16 +116,16 @@ class BoundedLineStage implements ModifierStage {
   ): Target {
     return this.getContaining(target, options, {
       type: "line",
-    })[0];
+    });
   }
 
   private getContaining(
     target: Target,
     options: ModifierStateOptions,
     scopeType: ScopeType,
-  ): Target[] {
+  ): Target {
     return this.modifierStageFactory
       .create({ type: "containingScope", scopeType })
-      .run(target, options);
+      .run(target, options)[0];
   }
 }