Skip to content

Commit 284a010

Browse files
committed
another CI attempt
1 parent e617ec8 commit 284a010

File tree

3 files changed

+24
-11
lines changed

3 files changed

+24
-11
lines changed

packages/test-harness/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,12 @@
3535
"tail": "2.2.6"
3636
},
3737
"devDependencies": {
38+
"@types/cross-spawn": "6.0.6",
3839
"@types/glob": "^8.1.0",
3940
"@types/mocha": "^10.0.9",
4041
"@types/tail": "2.2.3",
4142
"@vscode/test-electron": "^2.4.1",
43+
"cross-spawn": "7.0.3",
4244
"mocha": "^10.7.3"
4345
},
4446
"types": "./out/runners/extensionTestsNeovim.d.ts",

packages/test-harness/src/launchVscodeAndRunTests.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import {
88
resolveCliArgsFromVSCodeExecutablePath,
99
runTests,
1010
} from "@vscode/test-electron";
11-
import * as cp from "node:child_process";
1211
import * as os from "node:os";
1312
import * as path from "node:path";
13+
import { spawnSync } from "node:child_process";
1414

1515
/**
1616
* Downloads and launches VSCode, instructing it to run the test runner
@@ -53,10 +53,8 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) {
5353
console.log(`cli: ${cli}`);
5454
console.log(JSON.stringify(extensionInstallArgs, null, 2));
5555

56-
const { status, signal, error } = cp.spawnSync(cli, extensionInstallArgs, {
57-
encoding: "utf-8",
56+
const { status, signal, error } = spawnSync(cli, extensionInstallArgs, {
5857
stdio: "inherit",
59-
shell: true,
6058
});
6159

6260
console.log("status: ", status);

pnpm-lock.yaml

Lines changed: 20 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)