Skip to content

Commit 5456641

Browse files
Iteration-based scope handler interface (#1096)
* Iteration-based scope handler interface * Remove `getPreferredScopeTouchingPosition` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * `isPreferredOver` skeleton * Reintroduce token preferences * Attempt at more simplification * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Tweak hints * Cleanup * Remove `allowNoOverlap` from requirements * New RelativeInclusive semantics * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add tests * Migrate early stopping to base class * More doc tweaks * More doc tweaks * More docs * More docs * More docs * More doc strings * More cleanup * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * More docs * More docs * More docs * Fixes * More docs * More docstring tweaks * Tweak docs * Address PR comments * Tweak token `isPreferredOver` Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent cbeca1d commit 5456641

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

src/modifiers/modifiers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from .interior import interior_modifiers
66
from .ordinal_scope import first_modifiers, last_modifiers
77
from .range_type import range_types
8-
from .relative_scope import backward_modifiers, previous_next_modifiers
8+
from .relative_scope import forward_backward_modifiers, previous_next_modifiers
99
from .simple_scope_modifier import simple_scope_modifiers
1010

1111
mod = Module()
@@ -81,7 +81,7 @@ def on_ready():
8181
"first_modifier": first_modifiers,
8282
"last_modifier": last_modifiers,
8383
"previous_next_modifier": previous_next_modifiers,
84-
"backward_modifier": backward_modifiers,
84+
"forward_backward_modifier": forward_backward_modifiers,
8585
},
8686
)
8787

src/modifiers/relative_scope.py

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
from talon import Module
44

55
previous_next_modifiers = {"previous": "previous", "next": "next"}
6-
backward_modifiers = {"backward": "backward"}
6+
forward_backward_modifiers = {
7+
"forward": "forward",
8+
"backward": "backward",
9+
}
710

811
mod = Module()
912

1013
mod.list("cursorless_previous_next_modifier", desc="Cursorless previous/next modifiers")
11-
mod.list("cursorless_backward_modifier", desc="Cursorless backward modifiers")
14+
mod.list(
15+
"cursorless_forward_backward_modifier", desc="Cursorless forward/backward modifiers"
16+
)
1217

1318

1419
@mod.capture(rule="{user.cursorless_previous_next_modifier}")
@@ -44,26 +49,28 @@ def cursorless_relative_scope_plural(m) -> dict[str, Any]:
4449

4550

4651
@mod.capture(
47-
rule="<user.private_cursorless_number_small> <user.cursorless_scope_type_plural> [{user.cursorless_backward_modifier}]"
52+
rule="<user.private_cursorless_number_small> <user.cursorless_scope_type_plural> [{user.cursorless_forward_backward_modifier}]"
4853
)
4954
def cursorless_relative_scope_count(m) -> dict[str, Any]:
5055
"""Relative count scope. `three funks`"""
5156
return create_relative_scope_modifier(
5257
m.cursorless_scope_type_plural,
5358
0,
5459
m.private_cursorless_number_small,
55-
getattr(m, "cursorless_backward_modifier", "forward"),
60+
getattr(m, "cursorless_forward_backward_modifier", "forward"),
5661
)
5762

5863

59-
@mod.capture(rule="<user.cursorless_scope_type> {user.cursorless_backward_modifier}")
64+
@mod.capture(
65+
rule="<user.cursorless_scope_type> {user.cursorless_forward_backward_modifier}"
66+
)
6067
def cursorless_relative_scope_one_backward(m) -> dict[str, Any]:
6168
"""Take scope backward, eg `funk backward`"""
6269
return create_relative_scope_modifier(
6370
m.cursorless_scope_type,
6471
0,
6572
1,
66-
m.cursorless_backward_modifier,
73+
m.cursorless_forward_backward_modifier,
6774
)
6875

6976

0 commit comments

Comments
 (0)