Skip to content

Commit 640c774

Browse files
More refactoring
1 parent 694a050 commit 640c774

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/RangeLookupList.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ export class RangeLookupList<T extends { range: Range }> {
1010
/**
1111
* @param items The items to search in. Must be sorted in document order.
1212
*/
13-
constructor(public items: T[]) {}
13+
constructor(private items: T[]) {}
14+
15+
add(item: T) {
16+
this.items.push(item);
17+
}
1418

1519
contains(searchItem: Range): boolean {
1620
return this.advance(searchItem);

packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/RangeLookupTree.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function createNodes<T extends { range: Range }>(
4242
const parent = parents[parents.length - 1];
4343

4444
if (parent != null) {
45-
parent.children.items.push(node);
45+
parent.addChildNode(node);
4646
} else {
4747
results.push(node);
4848
}

packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/RangeTreeNode.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import type { Range } from "@cursorless/common";
22
import { RangeLookupList } from "./RangeLookupList";
33

44
export class RangeTreeNode<T extends { range: Range }> {
5-
children: RangeLookupList<RangeTreeNode<T>>;
5+
private children: RangeLookupList<RangeTreeNode<T>>;
66

77
constructor(private item: T) {
88
this.children = new RangeLookupList([]);
@@ -12,6 +12,10 @@ export class RangeTreeNode<T extends { range: Range }> {
1212
return this.item.range;
1313
}
1414

15+
addChildNode(node: RangeTreeNode<T>) {
16+
this.children.add(node);
17+
}
18+
1519
getSmallLestContaining(range: Range): T {
1620
const child = this.children
1721
.getContaining(range)

0 commit comments

Comments
 (0)