Reactivate reveal range on focus editor (#2437)

Was removed by mistake in

008baa1

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

Author: AndreasArvidsson

packages/common/src/types/TextEditor.ts

@@ -55,6 +55,7 @@ export interface TextEditor {
 
 export interface SetSelectionsOpts {
   focusEditor?: boolean;
+  revealRange?: boolean;
 }
 
 export interface EditableTextEditor extends TextEditor {

packages/cursorless-engine/src/actions/CallbackAction.ts

@@ -93,6 +93,7 @@ export class CallbackAction {
     if (options.setSelection) {
       await editableEditor.setSelections(targetSelections, {
         focusEditor: true,
+        revealRange: false,
       });
     }
 

packages/cursorless-vscode-e2e/src/suite/revealRange.vscode.test.ts

@@ -0,0 +1,66 @@
+import { openNewEditor } from "@cursorless/vscode-common";
+import * as vscode from "vscode";
+import { endToEndTestSetup } from "../endToEndTestSetup";
+import { runCursorlessCommand } from "@cursorless/vscode-common";
+import assert from "assert";
+
+suite("revealRange", async function () {
+  endToEndTestSetup(this);
+
+  test("pre file", preFile);
+  test("post file", postFile);
+});
+
+const content = new Array(100).fill("line").join("\n");
+
+async function preFile() {
+  const editor = await openNewEditor(content);
+  const startLine = editor.document.lineCount - 1;
+  editor.selections = [new vscode.Selection(startLine, 0, startLine, 0)];
+  editor.revealRange(new vscode.Range(startLine, 0, startLine, 0));
+
+  await runCursorlessCommand({
+    version: 7,
+    usePrePhraseSnapshot: false,
+    action: {
+      name: "setSelectionBefore",
+      target: {
+        type: "primitive",
+        modifiers: [
+          { type: "containingScope", scopeType: { type: "document" } },
+        ],
+      },
+    },
+  });
+
+  assert.equal(editor.visibleRanges.length, 1);
+  // FIXME: Disabled to work around CI failure; see #2243
+  //   assert.equal(editor.visibleRanges[0].start.line, 0);
+}
+
+async function postFile() {
+  const editor = await openNewEditor(content);
+  await vscode.commands.executeCommand("revealLine", {
+    lineNumber: 1,
+    at: "top",
+  });
+  editor.selections = [new vscode.Selection(0, 0, 0, 0)];
+
+  await runCursorlessCommand({
+    version: 7,
+    usePrePhraseSnapshot: false,
+    action: {
+      name: "setSelectionAfter",
+      target: {
+        type: "primitive",
+        modifiers: [
+          { type: "containingScope", scopeType: { type: "document" } },
+        ],
+      },
+    },
+  });
+
+  assert.equal(editor.visibleRanges.length, 1);
+  // FIXME: Disabled to work around CI failure; see #2243
+  //   assert.equal(editor.visibleRanges[0].end.line, editor.document.lineCount - 1);
+}

packages/cursorless-vscode/src/ide/vscode/VscodeTextEditorImpl.ts

@@ -57,7 +57,7 @@ export class VscodeTextEditorImpl implements EditableTextEditor {
 
   async setSelections(
     rawSelections: Selection[],
-    { focusEditor = false }: SetSelectionsOpts = {},
+    { focusEditor = false, revealRange = true }: SetSelectionsOpts = {},
   ): Promise<void> {
     const selections = uniqWithHash(
       rawSelections,
@@ -87,6 +87,10 @@ export class VscodeTextEditorImpl implements EditableTextEditor {
       this.editor.selections = selections;
       await vscodeFocusEditor(this);
     }
+
+    if (revealRange) {
+      await this.revealRange(this.selections[0]);
+    }
   }
 
   get visibleRanges(): Range[] {