Fix snippet insertion indentation (#1528)

- Fixes #1527

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Author: pokey

packages/cursorless-engine/src/processTargets/targets/PositionTarget.ts

@@ -44,8 +44,15 @@ export default class PositionTarget extends BaseTarget {
     if (
       this.insertionDelimiter === "\n" &&
       this.position === "after" &&
-      this.thatTarget.contentRange.isSingleLine
+      this.state.thatTarget!.contentRange.isSingleLine
     ) {
+      // If the target that we're wrapping is not a single line, then we
+      // want to compute indentation based on the entire target.  Otherwise,
+      // we allow the editor to determine how to perform indentation.
+      // Note that we use `this.state.thatTarget` rather than `this.thatTarget`
+      // because we don't really want the transitive `thatTarget` behaviour, as
+      // it's not really the "that" target that we're after; it's the target that
+      // we're wrapping.  Should rework this stuff as part of #803.
       return "insertLineAfter";
     }
 

packages/cursorless-vscode-e2e/src/suite/fixtures/cursorless-snippets/elseBranch.cursorless-snippets

@@ -0,0 +1,22 @@
+{
+  "elseStatement": {
+    "definitions": [
+      {
+        "scope": {
+          "langIds": [
+            "python"
+          ]
+        },
+        "body": [
+          "else:",
+          "\t$body"
+        ]
+      }
+    ],
+    "description": "Else branch",
+    "variables": {
+      "body": {}
+    },
+    "insertionScopeTypes": ["branch"]
+  }
+}

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/positions/snipElseAfterThis.yml

@@ -0,0 +1,31 @@
+languageId: python
+command:
+  version: 5
+  spokenForm: snip else after this
+  action:
+    name: insertSnippet
+    args:
+      - {type: named, name: elseStatement}
+  targets:
+    - type: primitive
+      mark: {type: cursor}
+      modifiers:
+        - {type: position, position: after}
+  usePrePhraseSnapshot: true
+initialState:
+  documentContents: |
+    if True:
+        aaa = "bbb"
+  selections:
+    - anchor: {line: 1, character: 7}
+      active: {line: 1, character: 7}
+  marks: {}
+finalState:
+  documentContents: |
+    if True:
+        aaa = "bbb"
+    else:
+        
+  selections:
+    - anchor: {line: 3, character: 4}
+      active: {line: 3, character: 4}