bump typescript => 5.2.2 (#1979)

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] Check source maps are working for extension
- [x] Check source maps are working in test files
- [x] Don't depend on esbuild in all packages?
- [x] Try running vsix from CI locally
- [-] Use two .. for update recorded tests script

---------

Co-authored-by: Andreas Arvidsson <[email protected]>

Author: pokey

.eslintrc.json

@@ -11,7 +11,7 @@
     "ecmaVersion": 6,
     "sourceType": "module"
   },
-  "plugins": ["@typescript-eslint", "unused-imports", "import"],
+  "plugins": ["@typescript-eslint", "unused-imports", "import", "unicorn"],
   "rules": {
     "import/no-relative-packages": "error",
     "@typescript-eslint/consistent-type-assertions": [
@@ -52,7 +52,8 @@
       "MemberExpression[object.property.name='constructor'][property.name='name']"
     ],
     "no-throw-literal": "warn",
-    "semi": "off"
+    "semi": "off",
+    "unicorn/prefer-module": "error"
   },
   "overrides": [
     {

.github/workflows/deploy.yaml

@@ -20,7 +20,7 @@ jobs:
       - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version-file: package.json
           cache: pnpm
       - run: pnpm --color install
       - run: pnpm --color compile

.github/workflows/pre-commit.yml

@@ -21,7 +21,7 @@ jobs:
       - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version-file: package.json
           cache: pnpm
       - run: pnpm --color install
       - uses: pre-commit/[email protected]

.github/workflows/test-docs.yml

@@ -16,6 +16,6 @@ jobs:
       - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version-file: package.json
           cache: pnpm
       - run: bash -x scripts/build-and-assemble-website.sh

.github/workflows/test.yml

@@ -31,7 +31,7 @@ jobs:
       - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version-file: package.json
           cache: pnpm
       - run: mkdir -p "${{ env.VSCODE_CRASH_DIR }}" "${{ env.VSCODE_LOGS_DIR }}"
         shell: bash

.pre-commit-config.yaml

@@ -63,14 +63,14 @@ repos:
         name: format-recorded-tests
         files: ^packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/.*/[^/]*\.yml$
         language: system
-        entry: pnpm exec tsx --conditions=cursorless:bundler packages/cursorless-engine/src/scripts/transformRecordedTests/index.ts
+        entry: pnpm exec ./packages/common/scripts/my-ts-node.js packages/cursorless-engine/src/scripts/transformRecordedTests/index.ts
   - repo: local
     hooks:
       - id: check-recorded-test-marks
         name: check-recorded-test-marks
         files: ^packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/.*/[^/]*\.yml$
         language: system
-        entry: pnpm exec tsx --conditions=cursorless:bundler packages/cursorless-engine/src/scripts/transformRecordedTests/index.ts --check-marks
+        entry: pnpm exec ./packages/common/scripts/my-ts-node.js packages/cursorless-engine/src/scripts/transformRecordedTests/index.ts --check-marks
   - repo: https://github.com/ikamensh/flynt/
     rev: "0.78"
     hooks:

.vscode/launch.json

@@ -34,7 +34,7 @@
       "args": [
         "--profile=cursorlessDevelopment",
         "--extensionDevelopmentPath=${workspaceFolder}/packages/cursorless-vscode/dist",
-        "--extensionTestsPath=${workspaceFolder}/packages/test-harness/out/runners/extensionTests"
+        "--extensionTestsPath=${workspaceFolder}/packages/test-harness/dist/extensionTests.cjs"
       ],
       "outFiles": ["${workspaceFolder}/**/out/**/*.js"],
       "preLaunchTask": "${defaultBuildTask}",
@@ -55,7 +55,7 @@
       "args": [
         "--profile=cursorlessDevelopment",
         "--extensionDevelopmentPath=${workspaceFolder}/packages/cursorless-vscode/dist",
-        "--extensionTestsPath=${workspaceFolder}/packages/test-harness/out/runners/extensionTests"
+        "--extensionTestsPath=${workspaceFolder}/packages/test-harness/dist/extensionTests.cjs"
       ],
       "outFiles": ["${workspaceFolder}/**/out/**/*.js"],
       "preLaunchTask": "Prepare test subset",
@@ -68,7 +68,7 @@
       "name": "Talon tests",
       "type": "node",
       "request": "launch",
-      "program": "${workspaceFolder}/packages/test-harness/out/scripts/runTalonTests",
+      "program": "${workspaceFolder}/packages/test-harness/dist/runTalonTests.cjs",
       "env": {
         "CURSORLESS_TEST": "true",
         "CURSORLESS_REPO_ROOT": "${workspaceFolder}"
@@ -84,7 +84,7 @@
       "name": "Talon tests subset",
       "type": "node",
       "request": "launch",
-      "program": "${workspaceFolder}/packages/test-harness/out/scripts/runTalonTests",
+      "program": "${workspaceFolder}/packages/test-harness/dist/runTalonTests.cjs",
       "env": {
         "CURSORLESS_TEST": "true",
         "CURSORLESS_RUN_TEST_SUBSET": "true",
@@ -101,7 +101,7 @@
       "name": "Unit tests only",
       "type": "node",
       "request": "launch",
-      "program": "${workspaceFolder}/packages/test-harness/out/scripts/runUnitTestsOnly",
+      "program": "${workspaceFolder}/packages/test-harness/dist/runUnitTestsOnly.cjs",
       "env": {
         "CURSORLESS_TEST": "true",
         "CURSORLESS_REPO_ROOT": "${workspaceFolder}"
@@ -125,7 +125,7 @@
       "args": [
         "--profile=cursorlessDevelopment",
         "--extensionDevelopmentPath=${workspaceFolder}/packages/cursorless-vscode/dist",
-        "--extensionTestsPath=${workspaceFolder}/packages/test-harness/out/runners/extensionTests"
+        "--extensionTestsPath=${workspaceFolder}/packages/test-harness/dist/extensionTests.cjs"
       ],
       "outFiles": ["${workspaceFolder}/**/out/**/*.js"],
       "preLaunchTask": "${defaultBuildTask}",
@@ -147,7 +147,7 @@
       "args": [
         "--profile=cursorlessDevelopment",
         "--extensionDevelopmentPath=${workspaceFolder}/packages/cursorless-vscode/dist",
-        "--extensionTestsPath=${workspaceFolder}/packages/test-harness/out/runners/extensionTests"
+        "--extensionTestsPath=${workspaceFolder}/packages/test-harness/dist/extensionTests.cjs"
       ],
       "outFiles": ["${workspaceFolder}/**/out/**/*.js"],
       "preLaunchTask": "${defaultBuildTask}",
@@ -160,7 +160,7 @@
       "name": "Update fixtures, unit tests only",
       "type": "node",
       "request": "launch",
-      "program": "${workspaceFolder}/packages/test-harness/out/scripts/runUnitTestsOnly",
+      "program": "${workspaceFolder}/packages/test-harness/dist/runUnitTestsOnly.cjs",
       "env": {
         "CURSORLESS_TEST": "true",
         "CURSORLESS_TEST_UPDATE_FIXTURES": "true",

.vscode/settings.json

@@ -24,5 +24,6 @@
   ],
   "files.eol": "\n",
   "typescript.enablePromptUseWorkspaceTsdk": true,
-  "typescript.tsdk": "node_modules/typescript/lib"
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "eslint.workingDirectories": [{ "pattern": "packages/*/" }]
 }

.vscode/tasks.json

@@ -5,7 +5,12 @@
   "tasks": [
     {
       "label": "Build",
-      "dependsOn": ["Populate dist", "ESBuild", "TSBuild"],
+      "dependsOn": [
+        "Populate dist",
+        "ESBuild",
+        "TSBuild",
+        "Build test harness"
+      ],
       "group": {
         "kind": "build",
         "isDefault": true
@@ -22,7 +27,17 @@
       "script": "esbuild",
       "path": "packages/cursorless-vscode",
       "presentation": {
-        "reveal": "never"
+        "reveal": "silent"
+      },
+      "group": "build"
+    },
+    {
+      "label": "Build test harness",
+      "type": "npm",
+      "script": "build",
+      "path": "packages/test-harness",
+      "presentation": {
+        "reveal": "silent"
       },
       "group": "build"
     },
@@ -32,7 +47,7 @@
       "script": "compile",
       "problemMatcher": "$tsc",
       "presentation": {
-        "reveal": "never"
+        "reveal": "silent"
       },
       "group": "build"
     },
@@ -42,7 +57,7 @@
       "script": "populate-dist",
       "path": "packages/cursorless-vscode",
       "presentation": {
-        "reveal": "never"
+        "reveal": "silent"
       },
       "group": "build"
     },
@@ -73,9 +88,25 @@
       "dependsOrder": "sequence",
       "group": "test"
     },
+    {
+      "label": "watch",
+      "dependsOn": ["Watch esbuild", "Watch typescript"],
+      "group": "build"
+    },
+    {
+      "type": "npm",
+      "script": "watch:esbuild",
+      "label": "Watch esbuild",
+      "isBackground": true,
+      "presentation": {
+        "reveal": "never"
+      },
+      "group": "build"
+    },
     {
       "type": "npm",
-      "script": "watch",
+      "script": "watch:tsc",
+      "label": "Watch typescript",
       "problemMatcher": "$tsc-watch",
       "isBackground": true,
       "presentation": {

docs/user/installation.md

@@ -15,7 +15,7 @@
 
 Clone repo into `~/.talon/user`
 
-```insert code:
+```bash
 cd ~/.talon/user
 git clone https://github.com/cursorless-dev/cursorless-talon.git cursorless-talon
 ```
@@ -24,7 +24,7 @@ Alternatively, access the directory by right clicking the Talon icon in taskbar,
 
 The folder structure should look something like the below:
 
-```insert code:
+```
 ~/.talon/user/community
 ~/.talon/user/community/apps
 ~/.talon/user/community/code
@@ -40,7 +40,7 @@ Now, restart Talon.
 
 Clone repo into `%AppData%\Talon\user`
 
-```insert code:
+```bash
 cd %AppData%\Talon\user
 git clone https://github.com/cursorless-dev/cursorless-talon.git cursorless-talon
 ```
@@ -49,7 +49,7 @@ Alternatively, access the directory by right clicking the Talon icon in taskbar,
 
 The folder structure should look something like the below:
 
-```insert code:
+```
 %AppData%\Talon\user\community
 %AppData%\Talon\user\community\apps
 %AppData%\Talon\user\community\code