Don't discard nodes with non adjacent error siblings

Author: AndreasArvidsson

data/fixtures/recorded/surroundingPair/changePair.yml

@@ -0,0 +1,25 @@
+languageId: typescriptreact
+command:
+  version: 7
+  spokenForm: change pair
+  action:
+    name: clearAndSetSelection
+    target:
+      type: primitive
+      modifiers:
+        - type: containingScope
+          scopeType: {type: surroundingPair, delimiter: any}
+  usePrePhraseSnapshot: false
+initialState:
+  documentContents: |
+    <div bbb={() => null}>hello &</div>
+  selections:
+    - anchor: {line: 0, character: 14}
+      active: {line: 0, character: 14}
+  marks: {}
+finalState:
+  documentContents: |
+    <div bbb=>hello &</div>
+  selections:
+    - anchor: {line: 0, character: 9}
+      active: {line: 0, character: 9}

packages/cursorless-engine/src/languages/TreeSitterQuery/isContainedInErrorNode.ts

@@ -6,10 +6,24 @@ import type { SyntaxNode } from "web-tree-sitter";
  * @returns True if the given node is contained in an error node
  */
 export function isContainedInErrorNode(node: SyntaxNode) {
-  let currentNode: SyntaxNode | null = node;
+  if (node.hasError) {
+    return true;
+  }
+
+  let currentNode: SyntaxNode | null = node.parent;
 
   while (currentNode != null) {
+    // Ancestral node has errors, but it was not siblings to the previous node
+    // that caused the problem. We don't want to discard a node when a sibling
+    // that isn't adjacent is erroring.
     if (currentNode.hasError) {
+      return false;
+    }
+    // A adjacent sibling node was causing the problem. ie we are right next to the error node.
+    if (
+      currentNode.previousSibling?.isError ||
+      currentNode.nextSibling?.isError
+    ) {
       return true;
     }
     currentNode = currentNode.parent;