Fix Windows CI by pinning node version (#2297)

Windows CI started failing due to a node.js regression. We should really
be pinning node, like we pin pnpm and all our pnpm dependencies. The
only things we don't want to pin are OS version and vscode version

This PR pins node and adds some debug output for the future

## Checklist

- [x] Pin node using technique removed from #2217
- [x] Double-check pnpm pinning
- [x] Keep some of the print statements here
- [x] Remove code that slices args
- [ ] Add checklist somewhere of versions to check when this kind of
thing happens
  - [ ] node version (note this will be pinned)
  - [ ] OS version
  - [ ] vscode version
- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet

Author: pokey

.github/workflows/deploy.yaml

@@ -20,7 +20,7 @@ jobs:
       - run: corepack enable
       - uses: actions/setup-node@v4
         with:
-          node-version-file: package.json
+          node-version-file: .nvmrc
           cache: pnpm
       - run: pnpm --color install
       - run: pnpm --color compile

.github/workflows/pre-commit.yml

@@ -21,7 +21,7 @@ jobs:
       - run: corepack enable
       - uses: actions/setup-node@v4
         with:
-          node-version-file: package.json
+          node-version-file: .nvmrc
           cache: pnpm
       - run: pnpm --color install
       - uses: pre-commit/[email protected]

.github/workflows/test-docs.yml

@@ -16,6 +16,6 @@ jobs:
       - run: corepack enable
       - uses: actions/setup-node@v4
         with:
-          node-version-file: package.json
+          node-version-file: .nvmrc
           cache: pnpm
       - run: bash -x scripts/build-and-assemble-website.sh

.github/workflows/test.yml

@@ -31,7 +31,7 @@ jobs:
       - run: corepack enable
       - uses: actions/setup-node@v4
         with:
-          node-version-file: package.json
+          node-version-file: .nvmrc
           cache: pnpm
       - run: mkdir -p "${{ env.VSCODE_CRASH_DIR }}" "${{ env.VSCODE_LOGS_DIR }}"
         shell: bash

.nvmrc

@@ -0,0 +1 @@
+v20.12.1

packages/test-harness/src/launchVscodeAndRunTests.ts

@@ -41,20 +41,26 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) {
       resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);
 
     // Install extension dependencies
-    cp.spawnSync(
-      cli,
-      [
-        ...args,
-        ...extensionDependencies.flatMap((dependency) => [
-          "--install-extension",
-          dependency,
-        ]),
-      ],
-      {
-        encoding: "utf-8",
-        stdio: "inherit",
-      },
-    );
+    const extensionInstallArgs = [
+      ...args,
+      ...extensionDependencies.flatMap((dependency) => [
+        "--install-extension",
+        dependency,
+      ]),
+    ];
+
+    console.log("starting to install dependency extensions");
+    console.log(`cli: ${cli}`);
+    console.log(JSON.stringify(extensionInstallArgs, null, 2));
+
+    const { status, signal, error } = cp.spawnSync(cli, extensionInstallArgs, {
+      encoding: "utf-8",
+      stdio: "inherit",
+    });
+
+    console.log("status: ", status);
+    console.log("signal: ", signal);
+    console.log("error: ", error);
 
     console.log("finished installing dependency extensions");