Remove join as attribute

Author: AndreasArvidsson

packages/cursorless-engine/src/actions/JoinLines.ts

@@ -61,9 +61,9 @@ function getEdits(editor: TextEditor, targets: Target[]): Edit[] {
 
   for (const target of targets) {
     const targetsEdits =
-      target.joinAs === "line"
-        ? getLineTargetEdits(target)
-        : getTokenTargetEdits(target);
+      target.textualType === "token"
+        ? getTokenTargetEdits(target)
+        : getLineTargetEdits(target);
 
     edits.push(...targetsEdits);
   }

packages/cursorless-engine/src/processTargets/targets/BaseTarget.ts

@@ -12,7 +12,6 @@ import { isEqual } from "lodash-es";
 import type { EditWithRangeUpdater } from "../../typings/Types";
 import type {
   Destination,
-  JoinAsType,
   Target,
   TextualType,
 } from "../../typings/target.types";
@@ -54,7 +53,6 @@ export abstract class BaseTarget<
   isImplicit = false;
   isNotebookCell = false;
   textualType: TextualType = "token";
-  joinAs: JoinAsType = "line";
 
   constructor(parameters: TParameters & CommonTargetParameters) {
     this.state = {

packages/cursorless-engine/src/processTargets/targets/TokenTarget.ts

@@ -1,9 +1,5 @@
 import type { Range } from "@cursorless/common";
-import type {
-  JoinAsType,
-  Target,
-  TextualType,
-} from "../../typings/target.types";
+import type { Target, TextualType } from "../../typings/target.types";
 import type { CommonTargetParameters } from "./BaseTarget";
 import { BaseTarget } from "./BaseTarget";
 import {
@@ -15,7 +11,6 @@ import {
 export class TokenTarget extends BaseTarget<CommonTargetParameters> {
   type = "TokenTarget";
   textualType: TextualType = "token";
-  joinAs: JoinAsType = "token";
   insertionDelimiter = " ";
 
   getLeadingDelimiterTarget(): Target | undefined {

packages/cursorless-engine/src/typings/target.types.ts

@@ -29,7 +29,6 @@ import type {
 import type { EditWithRangeUpdater } from "./Types";
 
 export type EditNewActionType = "edit" | "insertLineAfter";
-export type JoinAsType = "line" | "token";
 
 export type TextualType = "character" | "word" | "token" | "line";
 
@@ -52,9 +51,6 @@ export interface Target {
   /** Targets textual type. Is this target a line, a token, etc... */
   readonly textualType: TextualType;
 
-  /** Specifies how a target should be joined */
-  readonly joinAs: JoinAsType;
-
   /**
    * If `true`, then this target has an explicit scope type, and so should never
    * be automatically expanded to a containing scope.