move ensureCommandShape into common (required for neovim) (#2318)

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

Co-authored-by: Cedric Halbronn <[email protected]>

Author: saidelike

packages/common/src/index.ts

@@ -94,9 +94,11 @@ export * from "./util/itertools";
 export * from "./extensionDependencies";
 export * from "./FakeCommandServerApi";
 export * from "./types/TestCaseFixture";
+export * from "./util/ensureCommandShape";
 export * from "./util/getEnvironmentVariableStrict";
 export * from "./util/CompositeKeyDefaultMap";
 export * from "./util/toPlainObject";
+export * from "./util/type";
 export * from "./util/clientSupportsFallback";
 export * from "./scopeSupportFacets/scopeSupportFacets.types";
 export * from "./scopeSupportFacets/scopeSupportFacetInfos";

packages/cursorless-engine/src/core/commandVersionUpgrades/ensureCommandShape.ts renamed to packages/common/src/util/ensureCommandShape.ts

@@ -1,5 +1,7 @@
-import { ActionType, Command, PartialTargetV0V1 } from "@cursorless/common";
-import { isString } from "../../util/type";
+import { ActionType } from "../types/command/ActionDescriptor";
+import { Command } from "../types/command/command.types";
+import { PartialTargetV0V1 } from "../types/command/legacy/CommandV0V1.types";
+import { isString } from "./type";
 
 /**
  * Given a list of arguments, ensure that it has the right shape.

packages/cursorless-engine/src/util/type.ts renamed to packages/common/src/util/type.ts

@@ -4,6 +4,7 @@ import {
   FileSystem,
   Hats,
   IDE,
+  ensureCommandShape,
   ScopeProvider,
 } from "@cursorless/common";
 import {
@@ -14,7 +15,6 @@ import { Debug } from "./core/Debug";
 import { HatTokenMapImpl } from "./core/HatTokenMapImpl";
 import { Snippets } from "./core/Snippets";
 import { StoredTargetMap } from "./core/StoredTargets";
-import { ensureCommandShape } from "./core/commandVersionUpgrades/ensureCommandShape";
 import { RangeUpdater } from "./core/updateSelections/RangeUpdater";
 import { CustomSpokenFormGeneratorImpl } from "./generateSpokenForm/CustomSpokenFormGeneratorImpl";
 import { LanguageDefinitions } from "./languages/LanguageDefinitions";

packages/cursorless-engine/src/cursorlessEngine.ts

@@ -1,8 +1,7 @@
-import { SimpleSurroundingPairName } from "@cursorless/common";
+import { SimpleSurroundingPairName, isString } from "@cursorless/common";
 import { IndividualDelimiter } from "./types";
 import { delimiterToText } from "./delimiterMaps";
 import { concat, uniq } from "lodash";
-import { isString } from "../../../util/type";
 
 /**
  * Given a list of delimiters, returns a list where each element corresponds to