Skip to content

Commit c2a01d8

Browse files
committed
Don't dispose of individual subscriptions
1 parent 03165ad commit c2a01d8

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed
Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { Disposable, FileSystem, PathChangeListener } from "@cursorless/common";
2-
import * as vscode from "vscode";
32
import { RelativePattern, workspace } from "vscode";
43

54
export class VscodeFileSystem implements FileSystem {
@@ -9,11 +8,10 @@ export class VscodeFileSystem implements FileSystem {
98
new RelativePattern(path, "**"),
109
);
1110

12-
return vscode.Disposable.from(
13-
watcher,
14-
watcher.onDidChange(onDidChange),
15-
watcher.onDidCreate(onDidChange),
16-
watcher.onDidDelete(onDidChange),
17-
);
11+
watcher.onDidChange(onDidChange);
12+
watcher.onDidCreate(onDidChange);
13+
watcher.onDidDelete(onDidChange);
14+
15+
return watcher;
1816
}
1917
}

packages/cursorless-vscode/src/ide/vscode/hats/VscodeHatRenderer.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -414,10 +414,9 @@ function watchDir(
414414
new vscode.RelativePattern(path, `**/*${CURSORLESS_HAT_SHAPES_SUFFIX}`),
415415
);
416416

417-
return vscode.Disposable.from(
418-
hatsDirWatcher,
419-
hatsDirWatcher.onDidChange(onDidChange),
420-
hatsDirWatcher.onDidCreate(onDidChange),
421-
hatsDirWatcher.onDidDelete(onDidChange),
422-
);
417+
hatsDirWatcher.onDidChange(onDidChange);
418+
hatsDirWatcher.onDidCreate(onDidChange);
419+
hatsDirWatcher.onDidDelete(onDidChange);
420+
421+
return hatsDirWatcher;
423422
}

0 commit comments

Comments
 (0)