remove jupiter command and selection hack

Author: AndreasArvidsson

packages/common/src/types/TextEditor.ts

@@ -110,12 +110,8 @@ export interface EditableTextEditor extends TextEditor {
 
   /**
    * Edit a new new notebook cell above.
-   * @return A promise that resolves to a function that must be applied to any
-   * selections that should be updated as result of this operation. This is a
-   * horrible hack to work around the fact that in vscode the promise resolves
-   * before the edits have actually been performed.
    */
-  editNewNotebookCellAbove(): Promise<(selection: Selection) => Selection>;
+  editNewNotebookCellAbove(): Promise<void>;
 
   /**
    * Edit a new new notebook cell below.

packages/cursorless-engine/src/actions/EditNew/runNotebookCellTargets.ts

@@ -1,4 +1,3 @@
-import type { Selection } from "@cursorless/common";
 import { ide } from "../../singletons/ide.singleton";
 import type { Destination } from "../../typings/target.types";
 import { createThatMark, ensureSingleTarget } from "../../util/targetUtils";
@@ -23,18 +22,13 @@ export async function runEditNewNotebookCellTargets(
 
   await actions.setSelection.run([destination.target]);
 
-  let modifyThatMark = (selection: Selection) => selection;
   if (isAbove) {
-    modifyThatMark = await editor.editNewNotebookCellAbove();
+    await editor.editNewNotebookCellAbove();
   } else {
     await editor.editNewNotebookCellBelow();
   }
 
   const thatMark = createThatMark([destination.target.thatTarget]);
 
-  // Apply horrible hack to work around the fact that in vscode the promise
-  // resolves before the edits have actually been performed.
-  thatMark[0].selection = modifyThatMark(thatMark[0].selection);
-
   return { thatSelections: thatMark };
 }

packages/cursorless-everywhere-talon-core/src/ide/TalonJsEditor.ts

@@ -149,7 +149,7 @@ export class TalonJsEditor implements EditableTextEditor {
     throw new Error("extractVariable not implemented.");
   }
 
-  editNewNotebookCellAbove(): Promise<(_selection: Selection) => Selection> {
+  editNewNotebookCellAbove(): Promise<void> {
     throw new Error("editNewNotebookCellAbove not implemented.");
   }
 

packages/cursorless-vscode/src/ide/vscode/VscodeNotebooks.ts

@@ -24,10 +24,6 @@ import vscodeFocusEditor from "./VscodeFocusEditor";
 import { vscodeFold, vscodeUnfold } from "./VscodeFold";
 import type { VscodeIDE } from "./VscodeIDE";
 import { vscodeInsertSnippet } from "./VscodeInsertSnippets";
-import {
-  vscodeEditNewNotebookCellAbove,
-  vscodeEditNewNotebookCellBelow,
-} from "./VscodeNotebooks";
 import vscodeOpenLink from "./VscodeOpenLink";
 import { vscodeRevealLine } from "./VscodeRevealLine";
 import { VscodeTextDocumentImpl } from "./VscodeTextDocumentImpl";
@@ -137,14 +133,12 @@ export class VscodeTextEditorImpl implements EditableTextEditor {
     return vscodeFocusEditor(this);
   }
 
-  public editNewNotebookCellAbove(): Promise<
-    (selection: Selection) => Selection
-  > {
-    return vscodeEditNewNotebookCellAbove(this);
+  public async editNewNotebookCellAbove(): Promise<void> {
+    await vscode.commands.executeCommand("notebook.cell.insertCodeCellAbove");
   }
 
-  public editNewNotebookCellBelow(): Promise<void> {
-    return vscodeEditNewNotebookCellBelow(this);
+  public async editNewNotebookCellBelow(): Promise<void> {
+    await vscode.commands.executeCommand("notebook.cell.insertCodeCellBelow");
   }
 
   public openLink(

packages/cursorless-vscode/src/ide/vscode/VscodeTextEditorImpl.ts

@@ -107,9 +107,7 @@ export class NeovimTextEditorImpl implements EditableTextEditor {
     // throw Error("focus Not implemented");
   }
 
-  public editNewNotebookCellAbove(): Promise<
-    (selection: Selection) => Selection
-  > {
+  public editNewNotebookCellAbove(): Promise<void> {
     throw Error("editNewNotebookCellAbove Not implemented");
   }