-
-
Notifications
You must be signed in to change notification settings - Fork 92
Increase performance for Tree sitter matches #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We're going to test the performance of the test change and the captured to for loop rewrite separately so we can get a better sense for where the improvement is. The loop rewrite is still a nice code cleanliness change on its own, but we'd like to know how much more efficient it is to better calibrate JavaScript performance mentally. |
|
Now I have some data 529k lines json, 11 iterations, median value
|
|
Total performance improvement: 11.45%
|
First, were checking the captures against the SCM files in production, which was an oversight - should only be happening in debugging.
Secondarily, the existing implementation multiple map and filters. This part of the code is very time sensitive and can run quite long for large files since we are iterating every capture in the entire file.
This implementation aims to reduce iteration steps
Fixes #2656
Checklist