Skip to content

Commit 01aa111

Browse files
committed
refactor: base in-app message view
1 parent bb44d81 commit 01aa111

File tree

8 files changed

+302
-230
lines changed

8 files changed

+302
-230
lines changed

messaginginapp/api/messaginginapp.api

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public final class io/customer/messaginginapp/ModuleMessagingInApp$Companion {
3535
}
3636

3737
public final class io/customer/messaginginapp/databinding/ActivityGistBinding : androidx/viewbinding/ViewBinding {
38-
public final field gistView Lio/customer/messaginginapp/gist/presentation/GistView;
38+
public final field gistView Lio/customer/messaginginapp/ui/ModalInAppMessageView;
3939
public final field modalGistViewLayout Landroid/widget/RelativeLayout;
4040
public static fun bind (Landroid/view/View;)Lio/customer/messaginginapp/databinding/ActivityGistBinding;
4141
public synthetic fun getRoot ()Landroid/view/View;
@@ -154,12 +154,12 @@ public abstract interface class io/customer/messaginginapp/gist/presentation/Gis
154154
public abstract fun onMessageShown (Lio/customer/messaginginapp/gist/data/model/Message;)V
155155
}
156156

157-
public final class io/customer/messaginginapp/gist/presentation/GistModalActivity : androidx/appcompat/app/AppCompatActivity, io/customer/messaginginapp/gist/presentation/GistViewListener, io/customer/sdk/tracking/TrackableScreen {
157+
public final class io/customer/messaginginapp/gist/presentation/GistModalActivity : androidx/appcompat/app/AppCompatActivity, io/customer/messaginginapp/ui/InAppMessageHostViewListener, io/customer/sdk/tracking/TrackableScreen {
158158
public static final field Companion Lio/customer/messaginginapp/gist/presentation/GistModalActivity$Companion;
159159
public fun <init> ()V
160160
public fun finish ()V
161161
public fun getScreenName ()Ljava/lang/String;
162-
public fun onGistViewSizeChanged (II)V
162+
public fun onViewSizeChanged (II)V
163163
}
164164

165165
public final class io/customer/messaginginapp/gist/presentation/GistModalActivity$Companion {
@@ -187,32 +187,6 @@ public final class io/customer/messaginginapp/gist/presentation/GistSdk : io/cus
187187
public fun setUserId (Ljava/lang/String;)V
188188
}
189189

190-
public final class io/customer/messaginginapp/gist/presentation/GistView : android/widget/FrameLayout, io/customer/messaginginapp/gist/presentation/engine/EngineWebViewListener {
191-
public fun <init> (Landroid/content/Context;)V
192-
public fun <init> (Landroid/content/Context;Landroid/util/AttributeSet;)V
193-
public synthetic fun <init> (Landroid/content/Context;Landroid/util/AttributeSet;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
194-
public fun bootstrapped ()V
195-
public fun error ()V
196-
public final fun getListener ()Lio/customer/messaginginapp/gist/presentation/GistViewListener;
197-
public final fun getLogger ()Lio/customer/sdk/core/util/Logger;
198-
public fun routeChanged (Ljava/lang/String;)V
199-
public fun routeError (Ljava/lang/String;)V
200-
public fun routeLoaded (Ljava/lang/String;)V
201-
public final fun setListener (Lio/customer/messaginginapp/gist/presentation/GistViewListener;)V
202-
public final fun setup (Lio/customer/messaginginapp/gist/data/model/Message;)V
203-
public fun sizeChanged (DD)V
204-
public final fun stopLoading ()V
205-
public fun tap (Ljava/lang/String;Ljava/lang/String;Z)V
206-
}
207-
208-
public abstract interface class io/customer/messaginginapp/gist/presentation/GistViewListener {
209-
public abstract fun onGistViewSizeChanged (II)V
210-
}
211-
212-
public final class io/customer/messaginginapp/gist/presentation/GistViewListener$DefaultImpls {
213-
public static fun onGistViewSizeChanged (Lio/customer/messaginginapp/gist/presentation/GistViewListener;II)V
214-
}
215-
216190
public final class io/customer/messaginginapp/gist/presentation/engine/EngineWebViewInterface {
217191
public fun <init> (Lio/customer/messaginginapp/gist/presentation/engine/EngineWebViewListener;)V
218192
public final fun postMessage (Ljava/lang/String;)V

messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistModalActivity.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,15 @@ import io.customer.messaginginapp.gist.utilities.ModalAnimationUtil
2020
import io.customer.messaginginapp.state.InAppMessagingAction
2121
import io.customer.messaginginapp.state.InAppMessagingState
2222
import io.customer.messaginginapp.state.MessageState
23+
import io.customer.messaginginapp.ui.InAppMessageHostViewListener
2324
import io.customer.sdk.core.di.SDKComponent
2425
import io.customer.sdk.tracking.TrackableScreen
2526
import kotlinx.coroutines.Job
2627

2728
const val GIST_MESSAGE_INTENT: String = "GIST_MESSAGE"
2829
const val GIST_MODAL_POSITION_INTENT: String = "GIST_MODAL_POSITION"
2930

30-
class GistModalActivity : AppCompatActivity(), GistViewListener, TrackableScreen {
31+
class GistModalActivity : AppCompatActivity(), InAppMessageHostViewListener, TrackableScreen {
3132
private lateinit var binding: ActivityGistBinding
3233
private var elapsedTimer: ElapsedTimer = ElapsedTimer()
3334
private val inAppMessagingManager = SDKComponent.inAppMessagingManager
@@ -71,7 +72,7 @@ class GistModalActivity : AppCompatActivity(), GistViewListener, TrackableScreen
7172
logger.debug("GistModelActivity onCreate: $parsedMessage")
7273
parsedMessage.let { message ->
7374
elapsedTimer.start("Displaying modal for message: ${message.messageId}")
74-
binding.gistView.listener = this
75+
binding.gistView.viewListener = this
7576
binding.gistView.setup(message)
7677
val messagePosition = if (modalPositionStr == null) {
7778
message.gistProperties.position
@@ -193,7 +194,7 @@ class GistModalActivity : AppCompatActivity(), GistViewListener, TrackableScreen
193194
finish()
194195
}
195196

196-
override fun onGistViewSizeChanged(width: Int, height: Int) {
197+
override fun onViewSizeChanged(width: Int, height: Int) {
197198
logger.debug("GistModelActivity Size changed: $width x $height")
198199
val params = binding.gistView.layoutParams
199200
params.height = height

messaginginapp/src/main/java/io/customer/messaginginapp/gist/presentation/GistView.kt

Lines changed: 0 additions & 197 deletions
This file was deleted.

0 commit comments

Comments
 (0)