memory leak

Author: Shahroz16

location/src/main/kotlin/io/customer/location/LocationLifecycleObserver.kt

@@ -2,7 +2,6 @@ package io.customer.location
 
 import androidx.lifecycle.DefaultLifecycleObserver
 import androidx.lifecycle.LifecycleOwner
-import java.lang.ref.WeakReference
 
 /**
  * Manages location lifecycle tied to app foreground/background transitions.
@@ -12,33 +11,25 @@ import java.lang.ref.WeakReference
  *   when [trackingMode] is [LocationTrackingMode.ON_APP_START].
  * - [onStop]: cancels any in-flight GPS request when the app enters background.
  *
- * Uses a [WeakReference] to [LocationServicesImpl] so that [ProcessLifecycleOwner]
- * (which lives for the entire process) does not prevent SDK cleanup. When the SDK
- * is reset via [CustomerIO.clearInstance], the services become eligible for GC,
- * the weak reference clears, and this observer becomes a no-op.
- *
  * Thread safety: all lifecycle callbacks are delivered on the main thread
  * by [ProcessLifecycleOwner], so no synchronization is needed.
  */
 internal class LocationLifecycleObserver(
-    locationServices: LocationServicesImpl,
+    private val locationServices: LocationServicesImpl,
     private val trackingMode: LocationTrackingMode
 ) : DefaultLifecycleObserver {
 
-    private val servicesRef = WeakReference(locationServices)
     private var hasRequestedOnStart = false
 
     override fun onStart(owner: LifecycleOwner) {
-        val services = servicesRef.get() ?: return
         if (trackingMode == LocationTrackingMode.ON_APP_START && !hasRequestedOnStart) {
             hasRequestedOnStart = true
-            services.requestLocationUpdate()
+            locationServices.requestLocationUpdate()
         }
     }
 
     override fun onStop(owner: LifecycleOwner) {
-        val services = servicesRef.get() ?: return
-        val wasCancelled = services.cancelInFlightRequest()
+        val wasCancelled = locationServices.cancelInFlightRequest()
         // If the GPS request was still in flight when we backgrounded,
         // allow onStart to retry on the next foreground entry.
         if (wasCancelled) {

location/src/main/kotlin/io/customer/location/LocationTracker.kt

@@ -6,6 +6,7 @@ import io.customer.sdk.core.pipeline.DataPipeline
 import io.customer.sdk.core.pipeline.IdentifyHook
 import io.customer.sdk.core.util.Logger
 import io.customer.sdk.util.EventNames
+import java.lang.ref.WeakReference
 
 /**
  * Coordinates all location state management: persistence, restoration,
@@ -30,12 +31,18 @@ import io.customer.sdk.util.EventNames
  * sync filter's state.
  */
 internal class LocationTracker(
-    private val dataPipeline: DataPipeline?,
+    dataPipeline: DataPipeline?,
     private val locationPreferenceStore: LocationPreferenceStore,
     private val locationSyncFilter: LocationSyncFilter,
     private val logger: Logger
 ) : IdentifyHook {
 
+    // WeakReference prevents this hook (retained by IdentifyHookRegistry
+    // inside a Segment plugin) from keeping CustomerIO alive after SDK
+    // cleanup. The strong reference lives in CustomerIO.instance — as long
+    // as the SDK is initialized, the weak ref is valid.
+    private val dataPipelineRef = WeakReference(dataPipeline)
+
     @Volatile
     private var lastLocation: LocationCoordinates? = null
 
@@ -117,7 +124,7 @@ internal class LocationTracker(
      * track event via [DataPipeline] if both pass.
      */
     private fun trySendLocationTrack(latitude: Double, longitude: Double) {
-        val pipeline = dataPipeline ?: return
+        val pipeline = dataPipelineRef.get() ?: return
         if (!pipeline.isUserIdentified) return
         if (!locationSyncFilter.filterAndRecord(latitude, longitude)) return