fix: prevent tooltip live preview bar from immediately showing session ended state (#135)

Author: karngyan

src/managers/message-manager.ts

@@ -397,6 +397,16 @@ async function handleGistEvents(e: MessageEvent): Promise<void> {
             }
             const tooltipVisible = await showTooltipComponent(currentMessage);
             if (!tooltipVisible) {
+              const isLivePreview =
+                Gist.config.isPreviewSession && currentMessage.properties?.gist?.livePreview;
+              if (isLivePreview) {
+                log(
+                  `Preview: tooltip positioning failed for "${targetSelector}", preview bar will remain active`
+                );
+                currentMessage.firstLoad = false;
+                currentMessage.isDisplayChange = false;
+                break;
+              }
               log(
                 `Tooltip positioning failed for "${targetSelector}", emitting error and cleaning up`
               );

src/managers/preview-bar-manager.test.ts

@@ -37,6 +37,7 @@ import {
   initPreviewBar,
   updatePreviewBarMessage,
   updatePreviewBarStep,
+  clearPreviewBarMessage,
   destroyPreviewBar,
 } from './preview-bar-manager';
 
@@ -210,6 +211,38 @@ describe('preview-bar-manager', () => {
     });
   });
 
+  describe('clearPreviewBarMessage', () => {
+    it('shows session ended UI with countdown', () => {
+      initBarWithMessage();
+      clearPreviewBarMessage();
+
+      const bar = document.getElementById('gist-preview-bar')!;
+      expect(bar.querySelector('.gist-pb-ended-text')).not.toBeNull();
+      expect(bar.textContent).toContain('Refreshing in 5s');
+    });
+
+    it('prevents updatePreviewBarMessage from resetting session ended state', () => {
+      const message = initBarWithMessage();
+      clearPreviewBarMessage();
+
+      updatePreviewBarMessage(message);
+
+      const bar = document.getElementById('gist-preview-bar')!;
+      expect(bar.querySelector('.gist-pb-ended-text')).not.toBeNull();
+      expect(bar.querySelector('.gist-pb-save-btn')).toBeNull();
+    });
+
+    it('prevents updatePreviewBarStep from resetting session ended state', () => {
+      initBarWithMessage();
+      clearPreviewBarMessage();
+
+      updatePreviewBarStep('step-2', { displayType: 'modal' });
+
+      const bar = document.getElementById('gist-preview-bar')!;
+      expect(bar.querySelector('.gist-pb-ended-text')).not.toBeNull();
+    });
+  });
+
   describe('destroyPreviewBar', () => {
     it('removes the bar and styles from the DOM', () => {
       initPreviewBar();

src/managers/preview-bar-manager.ts

@@ -714,7 +714,7 @@ export function initPreviewBar(): void {
 }
 
 export function updatePreviewBarMessage(message: GistMessage): void {
-  isSessionEnded = false;
+  if (isSessionEnded) return;
   currentInstanceId = message.instanceId ?? null;
   const fullSettings = message.displaySettings as unknown;
   if (Array.isArray(fullSettings) && fullSettings.length > 0) {
@@ -773,6 +773,7 @@ export function updatePreviewBarMessage(message: GistMessage): void {
 }
 
 export function updatePreviewBarStep(stepName: string, displaySettings: DisplaySettings): void {
+  if (isSessionEnded) return;
   currentStepName = stepName;
   const step = currentSteps.find((s) => s.stepName === stepName);