refactor

Author: jcain3389

lib/vertex_client/responses/quotation_fallback.rb

@@ -29,25 +29,20 @@ def product_for_line_item(product)
 
       # see lib/vertex_client/rates.rb for hard-coded fallback rates
       def tax_amount(price, country, state)
-        if known_us_state?(country, state)
+        if domestic?(country) && state.present? && RATES['US'].has_key?(state)
+          # state is in the United States and we have an explicit fallback
           price * BigDecimal(RATES['US'][state])
-        elsif known_non_us_country?(country)
+        elsif !domestic?(country) && country.present? && RATES.has_key?(country)
+          # we have an explicit fallback for the country
           price * BigDecimal(RATES[country])
         else
           BigDecimal('0.0')
         end
       end
 
-      # state is in the United States and we have an explicit fallback
-      def known_us_state?(country, state)
-        return false if country.present? && country != 'US'
-
-        state.present? && RATES['US'].has_key?(state)
-      end
-
-      # we have an explicit fallback for the country
-      def known_non_us_country?(country)
-        country.present? && country != 'US' && RATES.has_key?(country)
+      def domestic?(country)
+        # we assume a country-less customer is from the US
+        country.nil? || country == 'US'
       end
 
       def tax_for_line_item(line_item)