move deepEquals, arrayEquals to external

Let external dependencies do what they do best.

Author: mscuthbert

README.md

@@ -124,7 +124,7 @@ testHTML directory as `sfElsewhereCDN.html`.
 
 ## Version
 
-0.21.2 (beta)
+0.21.3 (beta)
 
 ## License
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "music21j",
-  "version": "0.21.2",
+  "version": "0.21.3",
   "description": "A toolkit for computer-aided musicology, JavaScript version",
 
   "_main_etc": "these are the legacy urls; exports:. is the modern standard",
@@ -24,6 +24,8 @@
     "/webResources"
   ],
   "dependencies": {
+    "array-equal": "^2.0.0",
+    "deep-equal": "^2.2.3",
     "jsonpickle": "^1.2.0",
     "midicube": "^0.9.2",
     "vexflow": "^4.2.3"
@@ -36,6 +38,7 @@
   },
   "devDependencies": {
     "@playwright/test": "^1.57.0",
+    "@types/deep-equal": "^1.0.4",
     "@types/jquery": "^3.5.32",
     "@types/node": "^25.0.3",
     "@types/qunit": "^2.19.13",

package.json

@@ -8,6 +8,8 @@
  * Clef related objects and properties
  *
  */
+import arrayEqual from 'array-equal';
+
 import * as base from './base';
 import * as pitch from './pitch';
 import type { Stream } from './stream';
@@ -379,9 +381,6 @@ export function clefFromString(clefString: string, octaveShift: number = 0): Cle
         }
     }
 
-    // TODO: remove this -- we have other ways of deep equality
-    const arrayEqual = (a: any[], b: any[]) => a.length === b.length && a.every((el, ix) => el === b[ix]);
-
     const params = [thisType, lineNum, octaveShift];
     if (arrayEqual(params, ['G', 2, 0])) {
         return new TrebleClef();

src/chordTables.ts

@@ -351,22 +351,6 @@ export function urlParam(name: string): string {
         : decodeURIComponent(results[1].replace(/\+/g, ' '));
 }
 
-export function arrayEquals(a1: any[], a2: any[]): boolean {
-    if (a1.length !== a2.length) {
-        return false;
-    }
-    for (let i = 0; i < a1.length; i++) {
-        if (a1[i] instanceof Array && a2[i] instanceof Array) {
-            if (!arrayEquals(a1[i], a2[i])) {
-                return false;
-            }
-        } else if (a1[i] !== a2[i]) {
-            return false;
-        }
-    }
-    return true;
-}
-
 const _singletonCounter = {
     value: 0,
 };

src/clef.ts

@@ -84,7 +84,7 @@ import * as webmidi from './webmidi';
 
 import { debug } from './debug';
 
-export const VERSION = '0.21.2';
+export const VERSION = '0.21.3';
 
 export {
     MIDI,

src/common.ts

@@ -7,11 +7,12 @@
  * Copyright (c) 2013-24, Michael Scott Asato Cuthbert
  * Based on music21 (=music21p), Copyright (c) 2006-24, Michael Scott Asato Cuthbert
  */
+import deepEqual from 'deep-equal';
+
 import { Music21Exception } from './exceptions21';
 import { debug } from './debug';
 
 import * as base from './base';
-import * as common from './common';
 import * as interval from './interval';
 import * as pitch from './pitch';
 
@@ -85,11 +86,9 @@ export class AbstractScale extends Scale {
      * @returns {boolean}
      */
     equals(other: AbstractScale): boolean {
-        if (
-            common.arrayEquals(this.classes, other.classes)
-            && this.tonicDegree === other.tonicDegree
-            && common.arrayEquals(this._net, other._net)
-        ) {
+        if (deepEqual(this.classes, other.classes)
+                && this.tonicDegree === other.tonicDegree
+                && deepEqual(this._net, other._net)) {
             return true;
         } else {
             return false;