Skip to content

Commit a06cb88

Browse files
committed
more strings extracted
1 parent 49355b4 commit a06cb88

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

app/src/main/java/com/burhanrashid52/photoediting/EditImageActivity.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ class EditImageActivity : BaseActivity(), OnPhotoEditorListener, View.OnClickLis
223223
val intent = Intent()
224224
intent.type = "image/*"
225225
intent.action = Intent.ACTION_GET_CONTENT
226-
startActivityForResult(Intent.createChooser(intent, "Select Picture"), PICK_REQUEST)
226+
startActivityForResult(Intent.createChooser(intent, getString(R.string.msg_choose_image)), PICK_REQUEST)
227227
}
228228
}
229229
}
@@ -286,7 +286,7 @@ class EditImageActivity : BaseActivity(), OnPhotoEditorListener, View.OnClickLis
286286
if (saveBitmap == null) {
287287
Log.e(TAG, "saveAsBitmap -> onBitmapReady(null)")
288288
hideLoading()
289-
showSnackbar("Failed to save Image")
289+
showSnackbar(getString(R.string.msg_failed_to_save))
290290
return
291291
}
292292

@@ -301,12 +301,12 @@ class EditImageActivity : BaseActivity(), OnPhotoEditorListener, View.OnClickLis
301301
val result = it as? SaveImageResultSuccess?
302302
if (result != null) {
303303
hideLoading()
304-
showSnackbar("Image Saved Successfully")
304+
showSnackbar(getString(R.string.msg_image_saved))
305305
mSaveImageUri = result.uri ?: Uri.fromFile(result.file)
306306
mPhotoEditorView?.source?.setImageURI(mSaveImageUri)
307307
} else {
308308
hideLoading()
309-
showSnackbar("Failed to save Image")
309+
showSnackbar(getString(R.string.msg_failed_to_save))
310310
Log.e(
311311
TAG,
312312
"saveAsBitmap -> storeBitmap -> SaveImageResult Error ${it?.errorMessage}"
@@ -317,7 +317,7 @@ class EditImageActivity : BaseActivity(), OnPhotoEditorListener, View.OnClickLis
317317

318318
override fun onFailure(e: Exception?) {
319319
hideLoading()
320-
showSnackbar("Failed to save Image")
320+
showSnackbar(getString(R.string.msg_failed_to_save))
321321
Log.e(TAG, "saveAsBitmap -> onFailure", e)
322322
}
323323
})

app/src/main/res/values/strings.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@
174174
<string name="post_delete_suggestion">Delete suggestion</string>
175175

176176
<!-- Photo Editor-->
177+
<string name="app_intent_name">PhotoEditor</string>
177178
<string name="label_brush">Brush</string>
178179
<string name="label_shape">Shape</string>
179180
<string name="label_oval">Oval</string>
@@ -192,7 +193,9 @@
192193
<string name="label_save">Save</string>
193194
<string name="label_discard">Discard</string>
194195
<string name="msg_save_image">Do you want to exit without saving the image?</string>
195-
<string name="app_intent_name">PhotoEditor</string>
196196
<string name="msg_save_image_to_share">Please save image to share</string>
197197
<string name="msg_share_image">Share Image</string>
198+
<string name="msg_choose_image">Select an image</string>
199+
<string name="msg_image_saved">Image saved successfully</string>
200+
<string name="msg_failed_to_save">Failed to save image</string>
198201
</resources>

0 commit comments

Comments
 (0)