Skip to content

Commit a08e1a0

Browse files
committed
vulkan: add support for the atomic float ops extension
1 parent e0c1b4f commit a08e1a0

File tree

5 files changed

+33
-1
lines changed

5 files changed

+33
-1
lines changed

libavutil/hwcontext_vulkan.c

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ typedef struct VulkanDevicePriv {
9696
VkPhysicalDeviceVulkan12Features device_features_1_2;
9797
VkPhysicalDeviceVulkan13Features device_features_1_3;
9898
VkPhysicalDeviceDescriptorBufferFeaturesEXT desc_buf_features;
99+
VkPhysicalDeviceShaderAtomicFloatFeaturesEXT atomic_float_features;
99100

100101
/* Queues */
101102
pthread_mutex_t **qf_mutex;
@@ -401,6 +402,7 @@ static const VulkanOptExtension optional_device_exts[] = {
401402
{ VK_KHR_SAMPLER_YCBCR_CONVERSION_EXTENSION_NAME, FF_VK_EXT_NO_FLAG },
402403
{ VK_EXT_DESCRIPTOR_BUFFER_EXTENSION_NAME, FF_VK_EXT_DESCRIPTOR_BUFFER, },
403404
{ VK_EXT_PHYSICAL_DEVICE_DRM_EXTENSION_NAME, FF_VK_EXT_DEVICE_DRM },
405+
{ VK_EXT_SHADER_ATOMIC_FLOAT_EXTENSION_NAME, FF_VK_EXT_ATOMIC_FLOAT },
404406

405407
/* Imports/exports */
406408
{ VK_KHR_EXTERNAL_MEMORY_FD_EXTENSION_NAME, FF_VK_EXT_EXTERNAL_FD_MEMORY },
@@ -1202,9 +1204,13 @@ static int vulkan_device_create_internal(AVHWDeviceContext *ctx,
12021204
VkPhysicalDeviceTimelineSemaphoreFeatures timeline_features = {
12031205
.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES,
12041206
};
1207+
VkPhysicalDeviceShaderAtomicFloatFeaturesEXT atomic_float_features = {
1208+
.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_FLOAT_FEATURES_EXT,
1209+
.pNext = &timeline_features,
1210+
};
12051211
VkPhysicalDeviceDescriptorBufferFeaturesEXT desc_buf_features = {
12061212
.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_BUFFER_FEATURES_EXT,
1207-
.pNext = &timeline_features,
1213+
.pNext = &atomic_float_features,
12081214
};
12091215
VkPhysicalDeviceVulkan13Features dev_features_1_3 = {
12101216
.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_3_FEATURES,
@@ -1236,6 +1242,10 @@ static int vulkan_device_create_internal(AVHWDeviceContext *ctx,
12361242
p->device_features_1_3.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_3_FEATURES;
12371243
p->device_features_1_3.pNext = &p->desc_buf_features;
12381244
p->desc_buf_features.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_BUFFER_FEATURES_EXT;
1245+
p->desc_buf_features.pNext = &p->atomic_float_features;
1246+
p->atomic_float_features.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_FLOAT_FEATURES_EXT;
1247+
p->atomic_float_features.pNext = NULL;
1248+
12391249
ctx->free = vulkan_device_free;
12401250

12411251
/* Create an instance if not given one */
@@ -1290,6 +1300,9 @@ static int vulkan_device_create_internal(AVHWDeviceContext *ctx,
12901300
p->desc_buf_features.descriptorBuffer = desc_buf_features.descriptorBuffer;
12911301
p->desc_buf_features.descriptorBufferPushDescriptors = desc_buf_features.descriptorBufferPushDescriptors;
12921302

1303+
p->atomic_float_features.shaderBufferFloat32Atomics = atomic_float_features.shaderBufferFloat32Atomics;
1304+
p->atomic_float_features.shaderBufferFloat32AtomicAdd = atomic_float_features.shaderBufferFloat32AtomicAdd;
1305+
12931306
dev_info.pNext = &hwctx->device_features;
12941307

12951308
/* Setup queue family */

libavutil/vulkan.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,21 @@ int ff_vk_load_props(FFVulkanContext *s)
107107
.pNext = &s->driver_props,
108108
};
109109

110+
s->atomic_float_feats = (VkPhysicalDeviceShaderAtomicFloatFeaturesEXT) {
111+
.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_FLOAT_FEATURES_EXT,
112+
};
113+
s->feats_12 = (VkPhysicalDeviceVulkan12Features) {
114+
.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_2_FEATURES,
115+
.pNext = &s->atomic_float_feats,
116+
};
117+
s->feats = (VkPhysicalDeviceFeatures2) {
118+
.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2,
119+
.pNext = &s->feats_12,
120+
};
121+
110122
vk->GetPhysicalDeviceProperties2(s->hwctx->phys_dev, &s->props);
111123
vk->GetPhysicalDeviceMemoryProperties(s->hwctx->phys_dev, &s->mprops);
124+
vk->GetPhysicalDeviceFeatures2(s->hwctx->phys_dev, &s->feats);
112125

113126
if (s->qf_props)
114127
return 0;

libavutil/vulkan.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,10 @@ typedef struct FFVulkanContext {
240240
VkQueueFamilyProperties2 *qf_props;
241241
int tot_nb_qfs;
242242

243+
VkPhysicalDeviceShaderAtomicFloatFeaturesEXT atomic_float_feats;
244+
VkPhysicalDeviceVulkan12Features feats_12;
245+
VkPhysicalDeviceFeatures2 feats;
246+
243247
AVHWDeviceContext *device;
244248
AVVulkanDeviceContext *hwctx;
245249

libavutil/vulkan_functions.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ typedef enum FFVulkanExtensions {
4747
FF_VK_EXT_VIDEO_ENCODE_H264 = 1ULL << 15, /* VK_EXT_video_encode_h264 */
4848
FF_VK_EXT_VIDEO_ENCODE_H265 = 1ULL << 16, /* VK_EXT_video_encode_h265 */
4949
FF_VK_EXT_VIDEO_DECODE_AV1 = 1ULL << 17, /* VK_MESA_video_decode_av1 */
50+
FF_VK_EXT_ATOMIC_FLOAT = 1ULL << 18, /* VK_EXT_shader_atomic_float */
5051

5152
FF_VK_EXT_NO_FLAG = 1ULL << 31,
5253
} FFVulkanExtensions;

libavutil/vulkan_loader.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ static inline uint64_t ff_vk_extensions_to_mask(const char * const *extensions,
4545
{ VK_EXT_EXTERNAL_MEMORY_HOST_EXTENSION_NAME, FF_VK_EXT_EXTERNAL_HOST_MEMORY },
4646
{ VK_EXT_DEBUG_UTILS_EXTENSION_NAME, FF_VK_EXT_DEBUG_UTILS },
4747
{ VK_EXT_PHYSICAL_DEVICE_DRM_EXTENSION_NAME, FF_VK_EXT_DEVICE_DRM },
48+
{ VK_EXT_SHADER_ATOMIC_FLOAT_EXTENSION_NAME, FF_VK_EXT_ATOMIC_FLOAT },
4849
#ifdef _WIN32
4950
{ VK_KHR_EXTERNAL_MEMORY_WIN32_EXTENSION_NAME, FF_VK_EXT_EXTERNAL_WIN32_MEMORY },
5051
{ VK_KHR_EXTERNAL_SEMAPHORE_WIN32_EXTENSION_NAME, FF_VK_EXT_EXTERNAL_WIN32_SEM },

0 commit comments

Comments
 (0)