refactor: rebuild menu and settings

Author: cyb3rko

app/src/main/kotlin/de/cyb3rko/pincredible/fragments/HomeFragment.kt

@@ -26,7 +26,6 @@ import android.view.ViewGroup
 import androidx.activity.result.contract.ActivityResultContracts.StartActivityForResult
 import androidx.fragment.app.viewModels
 import androidx.lifecycle.lifecycleScope
-import androidx.navigation.NavDirections
 import androidx.navigation.fragment.findNavController
 import androidx.recyclerview.widget.LinearLayoutManager
 import de.cyb3rko.backpack.data.BuildInfo
@@ -162,10 +161,6 @@ class HomeFragment : BackpackMainFragment(), BackpackMainView {
         return Intent(myContext, SettingsActivity::class.java)
     }
 
-    override fun getAnalysisNavigation(): NavDirections {
-        return HomeFragmentDirections.homeToAnalysis()
-    }
-
     override fun getGithubLink(): Int {
         return R.string.github_link
     }

app/src/main/kotlin/de/cyb3rko/pincredible/fragments/SettingsFragment.kt

@@ -19,6 +19,7 @@ package de.cyb3rko.pincredible.fragments
 import android.graphics.drawable.Drawable
 import android.os.Bundle
 import androidx.core.content.res.ResourcesCompat
+import de.cyb3rko.backpack.fragments.BackpackAnalysisFragment
 import de.cyb3rko.backpack.fragments.BackpackSettingsFragment
 import de.cyb3rko.backpack.interfaces.BackpackSettingsView
 import de.cyb3rko.pincredible.R
@@ -44,4 +45,8 @@ internal class SettingsFragment : BackpackSettingsFragment(), BackpackSettingsVi
     override fun getAppIcon(): Drawable {
         return ResourcesCompat.getDrawable(resources, R.mipmap.ic_launcher, null)!!
     }
+
+    override fun getAnalysisFragment(): BackpackAnalysisFragment {
+        return AnalysisFragment()
+    }
 }

app/src/main/res/drawable/avatar.png

@@ -24,12 +24,6 @@
             app:enterAnim="@anim/shrink_in"
             app:popExitAnim="@anim/shrink_out" />
 
-        <action
-            android:id="@+id/home_to_analysis"
-            app:destination="@id/AnalysisFragment"
-            app:enterAnim="@anim/shrink_in"
-            app:popExitAnim="@anim/shrink_out" />
-
     </fragment>
 
     <fragment
@@ -65,16 +59,4 @@
 
     </fragment>
 
-    <fragment
-        android:id="@+id/AnalysisFragment"
-        android:label="@string/menu_home_analysis"
-        android:name="de.cyb3rko.pincredible.fragments.AnalysisFragment"
-        tools:layout="@layout/fragment_analysis">
-
-        <action
-            android:id="@+id/analysis_to_home"
-            app:destination="@id/HomeFragment" />
-
-    </fragment>
-
 </navigation>

app/src/main/res/navigation/nav_graph.xml

@@ -62,6 +62,7 @@
     <string name="toast_stacktrace">Stracktrace copied</string>
 
     <!-- Preferences -->
+    <string name="preference_about">by Cyb3rKo</string>
     <string name="preference_category_security">Security</string>
     <string name="preference_item_button_randomizer">Digit Button Randomizer</string>
     <string name="preference_item_button_randomizer_summary">Shuffle digit buttons for protection against touch location logging</string>
@@ -74,6 +75,9 @@
     <string name="preference_item_coordinate_frame">Coordinate Frame</string>
     <string name="preference_item_app_icon">App Icon</string>
     <string name="preference_item_app_icon_summary">Change the app\'s icon and label</string>
+    <string name="preference_category_other">Other</string>
+    <string name="preference_item_analysis">App analysis</string>
+    <string name="preference_item_analysis_summary">Access different checks related to security features</string>
     <string name="dialog_restart_title">Restart required</string>
     <string name="dialog_restart_message">The change will be visible on next app start.\n\nDo you want to restart now?</string>
     <string name="dialog_restart_button2">Later</string>

app/src/main/res/values/strings.xml

@@ -2,13 +2,20 @@
 <PreferenceScreen
     xmlns:app="http://schemas.android.com/apk/res-auto">
 
+    <Preference
+        app:key="about"
+        app:title="@string/app_name"
+        app:summary="@string/preference_about"
+        app:icon="@drawable/avatar" />
+
     <PreferenceCategory
         app:title="@string/preference_category_security">
 
         <SwitchPreferenceCompat
             app:key="app_lock"
             app:defaultValue="false"
             app:singleLineTitle="false"
+            app:enabled="false"
             app:title="@string/preference_item_app_lock"
             app:summary="@string/preference_item_app_lock_summary"
             app:icon="@drawable/colored_ic_biometry" />
@@ -63,4 +70,16 @@
 
     </PreferenceCategory>
 
+    <PreferenceCategory
+        app:title="@string/preference_category_other">
+
+        <Preference
+            app:key="analysis"
+            app:singleLineTitle="false"
+            app:title="@string/preference_item_analysis"
+            app:summary="@string/preference_item_analysis_summary"
+            app:useSimpleSummaryProvider="true" />
+
+    </PreferenceCategory>
+
 </PreferenceScreen>