Skip to content

Commit 284fab6

Browse files
IDSEC-000: Fix missing types on converters
1 parent ba6b0d4 commit 284fab6

File tree

4 files changed

+26
-19
lines changed

4 files changed

+26
-19
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.1.11
1+
0.1.12

docs/guides/creating_sia_rdp_strong_accounts.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ The workflow demonstrates creating strong accounts for different scenarios:
4848
- Domain administrator accounts
4949
- Accounts with different credential formats
5050

51-
## Basic Strong Account (Local Admin)
51+
### Basic Strong Account (Local Admin)
5252

5353
main.tf
5454
```terraform
@@ -123,7 +123,7 @@ variable "secret_description" {
123123

124124
---
125125

126-
## Domain Administrator Strong Account
126+
### Domain Administrator Strong Account
127127

128128
main.tf
129129
```terraform
@@ -202,7 +202,7 @@ variable "secret_description" {
202202

203203
---
204204

205-
## Privilege Cloud Account Reference
205+
### Privilege Cloud Account Reference
206206

207207
For production environments, reference credentials stored in Privilege Cloud:
208208

@@ -281,7 +281,7 @@ variable "secret_description" {
281281

282282
---
283283

284-
# Username Format Examples
284+
## Username Format Examples
285285

286286
The `provisioner_username` field supports various formats:
287287

@@ -294,9 +294,9 @@ The `provisioner_username` field supports various formats:
294294

295295
---
296296

297-
# Managing Account Lifecycle
297+
## Managing Account Lifecycle
298298

299-
## Rotating Credentials
299+
### Rotating Credentials
300300

301301
Update the password by changing the `provisioner_password`:
302302

@@ -316,7 +316,7 @@ resource "idsec_sia_secrets_vm" "admin_account" {
316316

317317
---
318318

319-
# Best Practices
319+
## Best Practices
320320

321321
1. **Use descriptive names**: Include purpose or environment in `secret_name` (e.g., `Prod-WebServers-RDP`)
322322
2. **Use PCloudAccount for production**: Leverage Privilege Cloud's password rotation and audit features
@@ -325,15 +325,15 @@ resource "idsec_sia_secrets_vm" "admin_account" {
325325

326326
---
327327

328-
# Related Resources
328+
## Related Resources
329329

330330
- [Creating RDP Target Sets](creating_sia_rdp_target_sets.md) - Associate strong accounts with Windows targets
331331
- [Managing RDP Target Sets and Secrets](managing_rdp_target_sets_and_secrets.md) - Comprehensive management guide
332332
- [Provisioning RDP Access](provisioning_rdp_access.md) - End-to-end RDP access setup
333333

334334
---
335335

336-
# Additional Information
336+
## Additional Information
337337

338338
For more details on the resources used in this workflow:
339339

internal/schemas/schemas_common_converters.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,10 +238,17 @@ func attrToInterface(key string, val attr.Value, prototype interface{}) (interfa
238238
switch v := val.(type) {
239239
case types.String:
240240
return v.ValueString(), nil
241+
case types.Number:
242+
value, _ := v.ValueBigFloat().Float64()
243+
return value, nil
244+
case types.Int32:
245+
return v.ValueInt32(), nil
241246
case types.Int64:
242247
return v.ValueInt64(), nil
243248
case types.Bool:
244249
return v.ValueBool(), nil
250+
case types.Float32:
251+
return v.ValueFloat32(), nil
245252
case types.Float64:
246253
return v.ValueFloat64(), nil
247254
case types.Object:

templates/guides/creating_sia_rdp_strong_accounts.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ The workflow demonstrates creating strong accounts for different scenarios:
4848
- Domain administrator accounts
4949
- Accounts with different credential formats
5050

51-
## Basic Strong Account (Local Admin)
51+
### Basic Strong Account (Local Admin)
5252

5353
main.tf
5454
```terraform
@@ -115,7 +115,7 @@ variable "secret_description" {
115115

116116
---
117117

118-
## Domain Administrator Strong Account
118+
### Domain Administrator Strong Account
119119

120120
main.tf
121121
```terraform
@@ -186,7 +186,7 @@ variable "secret_description" {
186186

187187
---
188188

189-
## Privilege Cloud Account Reference
189+
### Privilege Cloud Account Reference
190190

191191
For production environments, reference credentials stored in Privilege Cloud:
192192

@@ -257,7 +257,7 @@ variable "secret_description" {
257257

258258
---
259259

260-
# Username Format Examples
260+
## Username Format Examples
261261

262262
The `provisioner_username` field supports various formats:
263263

@@ -270,9 +270,9 @@ The `provisioner_username` field supports various formats:
270270

271271
---
272272

273-
# Managing Account Lifecycle
273+
## Managing Account Lifecycle
274274

275-
## Rotating Credentials
275+
### Rotating Credentials
276276

277277
Update the password by changing the `provisioner_password`:
278278

@@ -292,7 +292,7 @@ resource "idsec_sia_secrets_vm" "admin_account" {
292292

293293
---
294294

295-
# Best Practices
295+
## Best Practices
296296

297297
1. **Use descriptive names**: Include purpose or environment in `secret_name` (e.g., `Prod-WebServers-RDP`)
298298
2. **Use PCloudAccount for production**: Leverage Privilege Cloud's password rotation and audit features
@@ -301,15 +301,15 @@ resource "idsec_sia_secrets_vm" "admin_account" {
301301

302302
---
303303

304-
# Related Resources
304+
## Related Resources
305305

306306
- [Creating RDP Target Sets](creating_sia_rdp_target_sets.md) - Associate strong accounts with Windows targets
307307
- [Managing RDP Target Sets and Secrets](managing_rdp_target_sets_and_secrets.md) - Comprehensive management guide
308308
- [Provisioning RDP Access](provisioning_rdp_access.md) - End-to-end RDP access setup
309309

310310
---
311311

312-
# Additional Information
312+
## Additional Information
313313

314314
For more details on the resources used in this workflow:
315315

0 commit comments

Comments
 (0)