Skip to content

Commit 19b7a18

Browse files
author
Benjamin Délèze
authored
Merge pull request #6066 from cyberbotics/sync-master-2ffbd626a
Merge master into develop
2 parents 623d11a + d11b502 commit 19b7a18

File tree

8 files changed

+22
-6
lines changed

8 files changed

+22
-6
lines changed

dependencies/Makefile.linux

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ include $(WEBOTS_HOME)/resources/Makefile.os.include
66

77
DEPENDENCIES_URL = https://cyberbotics.com/files/repository/dependencies/linux64/release
88

9-
QT_VERSION = 6.2.3
9+
QT_VERSION = 6.4.3
1010
QT_PACKAGE = webots-qt-$(QT_VERSION)-linux64-release.tar.bz2
1111
OPENAL_PACKAGE = openal-linux64-1.16.0.tar.bz2
1212
OIS_PACKAGE = libOIS.1.4.tar.bz2
@@ -53,7 +53,7 @@ $(WEBOTS_DEPENDENCY_PATH)/$(QT_PACKAGE):
5353
@rm -f $(WEBOTS_DEPENDENCY_PATH)/$(QT_PACKAGE)
5454
@echo "# downloading $(QT_PACKAGE)"
5555
@wget -qq $(DEPENDENCIES_URL)/$(QT_PACKAGE) -P $(WEBOTS_DEPENDENCY_PATH)
56-
@if [ "$$(md5sum $(QT_PACKAGE) | awk '{print $$1;}')" != "edaea63de3772637993cb3facdd51d26" ]; then echo "MD5 checksum failed for $(QT_PACKAGE)"; exit 1; fi
56+
@if [ "$$(md5sum $(QT_PACKAGE) | awk '{print $$1;}')" != "a5448e2005fa981278f5348b43809932" ]; then echo "MD5 checksum failed for $(QT_PACKAGE)"; exit 1; fi
5757
@touch $(WEBOTS_DEPENDENCY_PATH)/$(QT_PACKAGE)
5858

5959

docs/reference/changelog-r2023.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ Released on ??
6969
- Fixed unwanted altitude change when reaching a target waypoint in `mavic2pro_patrol.c` ([#5981](https://github.com/cyberbotics/webots/pull/5981)).
7070
- Fixed the extern controller connection to a target Webots instance when a snap one is running ([#6002](https://github.com/cyberbotics/webots/pull/6002)).
7171
- Fixed the double downloading of meshes ([#6034](https://github.com/cyberbotics/webots/pull/6034)).
72+
- Fixed the loading of remote mesh bounding objects ([#6047](https://github.com/cyberbotics/webots/pull/6047)).
7273

7374
## Webots R2023a
7475
Released on November 29th, 2022.

scripts/install/qt_linux_installer.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ set -e
55

66
# follow the instructions from https://github.com/cyberbotics/webots/wiki/Qt-compilation#linux to download and compile Qt before executing this script.
77

8-
QT_VERSION=6.2.3
8+
QT_VERSION=6.4.3
99
ICU_VERSION=56
1010
QT_INSTALLATION_PATH=~/Qt/${QT_VERSION}/gcc_64
1111
WEBOTS_HOME="$(cd "$(dirname "${BASH_SOURCE[0]}" )"/../.. && pwd)"

src/webots/nodes/WbFluid.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ class WbFluid : public WbMatter {
4747
public slots:
4848
// recursions through solid children with bounding objects for material updates
4949
void propagateBoundingObjectMaterialUpdate(bool onSelection = false) override;
50+
void updateBoundingObject() override;
5051

5152
protected:
5253
// this constructor is reserved for derived classes only
@@ -81,7 +82,6 @@ public slots:
8182

8283
private slots:
8384
void createOdeGeomFromInsertedGroupItem(WbBaseNode *node) override;
84-
void updateBoundingObject() override;
8585
void updateStreamVelocity();
8686
void updateDensity();
8787
void updateViscosity();

src/webots/nodes/WbMatter.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ class WbMatter : public WbTransform {
8989
public slots:
9090
// recursions through bounding objects for material updates
9191
virtual void propagateBoundingObjectMaterialUpdate(bool onSelection = false) = 0;
92+
virtual void updateBoundingObject() = 0;
9293

9394
protected:
9495
// Abstract class: constructors are reserved for derived classes only
@@ -179,7 +180,6 @@ protected slots:
179180
static bool cShowMatterCenter;
180181

181182
private slots:
182-
virtual void updateBoundingObject() = 0;
183183
virtual void createOdeGeomFromInsertedGroupItem(WbBaseNode *node) = 0;
184184
void createOdeGeomFromInsertedTransformItem();
185185
void createOdeGeomFromInsertedShapeItem();

src/webots/nodes/WbMesh.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
#include "WbField.hpp"
2121
#include "WbGroup.hpp"
2222
#include "WbMFString.hpp"
23+
#include "WbMatter.hpp"
2324
#include "WbNetwork.hpp"
25+
#include "WbNodeUtilities.hpp"
2426
#include "WbResizeManipulator.hpp"
2527
#include "WbTriangleMesh.hpp"
2628
#include "WbUrl.hpp"
@@ -84,6 +86,12 @@ void WbMesh::downloadUpdate() {
8486
WbGroup *group = dynamic_cast<WbGroup *>(const_cast<WbNode *>(ancestor));
8587
if (group)
8688
group->recomputeBoundingSphere();
89+
90+
if (isInBoundingObject()) {
91+
WbMatter *boundingObjectAncestor = WbNodeUtilities::findBoundingObjectAncestor(this);
92+
if (boundingObjectAncestor)
93+
boundingObjectAncestor->updateBoundingObject();
94+
}
8795
}
8896

8997
void WbMesh::preFinalize() {

src/webots/nodes/WbSolid.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,12 @@ void WbSolid::validateProtoNode() {
260260
}
261261
}
262262

263+
void WbSolid::downloadAssets() {
264+
WbGroup::downloadAssets();
265+
if (boundingObject())
266+
boundingObject()->downloadAssets();
267+
}
268+
263269
void WbSolid::preFinalize() {
264270
mHasNoSolidAncestor = false;
265271

src/webots/nodes/WbSolid.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ class WbSolid : public WbMatter {
5454

5555
// reimplemented public functions
5656
int nodeType() const override { return WB_NODE_SOLID; }
57+
void downloadAssets() override;
5758
void createWrenObjects() override;
5859
void preFinalize() override;
5960
void validateProtoNode() override;
@@ -245,6 +246,7 @@ public slots:
245246
void updateGraphicalGlobalCenterOfMass();
246247
void resetPhysicsIfRequired(bool changedFromSupervisor);
247248
virtual void updateChildren();
249+
void updateBoundingObject() override;
248250

249251
protected:
250252
// this constructor is reserved for derived classes only
@@ -461,7 +463,6 @@ private slots:
461463
void updatePhysics();
462464
void updateRadarCrossSection();
463465
void updateRecognitionColors();
464-
void updateBoundingObject() override;
465466
void updateOdeMass();
466467
void applyToOdeMass();
467468
void updateOdeInertiaMatrix();

0 commit comments

Comments
 (0)