Clarify Robot Window HTML Test (#6755)

* fix race condition

* run test on all platforms

* fix test message to reference correct controller

* use non-snap firefox

* copy previous commit to main CI script

* define UBUNTU_VERSION

* add sudo to scripts

* use correct formatting in apt preferences

* specify apt repo in command instead of preferences

* debugging

* clarify logic

* revert firefox changes

* revert test-suite change

* Revert "debugging"

This reverts commit eb14586.

* clarify variable initializations

* disable robot_window_html test in CI

* reenable test on non-linux platforms

* cleanup

Author: CoolSpy3

tests/api/controllers/robot_window_html/robot_window_html.c

@@ -7,27 +7,26 @@
 #define TIME_STEP 32
 
 int main(int argc, char **argv) {
-  bool configured = false, received = false;
   ts_setup(argv[0]);
 
-  while (!configured) {  // receive message sent by the robot window.
+  for (;;) {  // receive message sent by the robot window.
     wb_robot_step(TIME_STEP);
-    const char *configure_message;
-    while ((configure_message = wb_robot_wwi_receive_text())) {
+    const char *configure_message = wb_robot_wwi_receive_text();
+    if (configure_message) {
       if (strcmp(configure_message, "configure") == 0) {
-        configured = true;
-        wb_robot_wwi_send_text("test wwi functions from complete_test controller.");
+        wb_robot_wwi_send_text("test wwi functions from robot_window_html controller.");
+        break;
       } else
         ts_send_error_and_exit("Wrong configure message received from the HTML robot-window: %s", configure_message);
     }
   }
 
-  while (!received) {  // receive message sent by Webots.
+  for (;;) {  // receive message sent by Webots.
     wb_robot_step(TIME_STEP);
-    const char *test_message;
-    while ((test_message = wb_robot_wwi_receive_text())) {
-      if (strcmp(test_message, "Answer: test wwi functions from complete_test controller.") == 0)
-        received = true;
+    const char *test_message = wb_robot_wwi_receive_text();
+    if (test_message) {
+      if (strcmp(test_message, "Answer: test wwi functions from robot_window_html controller.") == 0)
+        break;
       else
         ts_send_error_and_exit("Wrong test message received from the HTML robot-window: %s", test_message);
     }

tests/test_suite.py

@@ -199,17 +199,19 @@ def generateWorldsList(groupName):
         # to file
         for filename in filenames:
             # speaker test not working on github action because of missing sound drivers
-            # robot window and movie recording test not working on BETA Ubuntu 22.04 GitHub Action environment
+            # robot window test cannot open a browser for the robot window in a headless environment
+            #       on non-mac operating systems
+            # movie recording test not working on BETA Ubuntu 22.04 GitHub Action environment
             # billboard test not working in macos GitHub Action environment
             # billboard and robot window not working on windows GitHub Action environment.
             if (not filename.endswith('_temp.wbt') and
                     not ('GITHUB_ACTIONS' in os.environ and (
                         filename.endswith('speaker.wbt') or
                         filename.endswith('local_proto_with_texture.wbt') or
-                        (filename.endswith('robot_window_html.wbt') and is_ubuntu_22_04) or
                         (filename.endswith('supervisor_start_stop_movie.wbt') and is_ubuntu_22_04) or
                         (filename.endswith('billboard.wbt') and sys.platform == 'darwin') or
                         (filename.endswith('billboard.wbt') and sys.platform == 'win32') or
+                        (filename.endswith('robot_window_html.wbt') and sys.platform == 'linux') or
                         (filename.endswith('robot_window_html.wbt') and sys.platform == 'win32')
                     ))):
                 worldsList.append(filename)