Skip to content

Commit a363a56

Browse files
author
Benjamin Délèze
authored
Merge pull request #6104 from cyberbotics/sync-master-50e74d6ba
Merge master into develop
2 parents c48c426 + 108942e commit a363a56

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

docs/reference/changelog-r2023.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ Released on ??
7777
- Fixed the double downloading of meshes ([#6034](https://github.com/cyberbotics/webots/pull/6034)).
7878
- Fixed generation of moment of inertia matrix based on bounding box ([#6048](https://github.com/cyberbotics/webots/pull/6048)).
7979
- Fixed the loading of remote mesh bounding objects ([#6047](https://github.com/cyberbotics/webots/pull/6047)).
80+
- Fixed crash during conversion of PROTO to base nodes in case of Mesh nodes with invalid scale values ([#6088](https://github.com/cyberbotics/webots/pull/6088)).
8081

8182
## Webots R2023a
8283
Released on November 29th, 2022.

src/webots/nodes/WbCadShape.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -268,11 +268,7 @@ QStringList WbCadShape::objMaterialList(const QString &url) const {
268268
if (!cleanLine.startsWith("mtllib"))
269269
continue;
270270

271-
cleanLine = cleanLine.replace("mtllib ", "").trimmed();
272-
cleanLine = cleanLine.replace("\"", "");
273-
materials << cleanLine.split(".mtl ", Qt::SkipEmptyParts);
274-
for (int i = 0; i < materials.size() - 1; i++) // the last item still have '.mtl'
275-
materials[i] += ".mtl";
271+
materials << cleanLine.replace("mtllib ", "").replace("\"", "").trimmed();
276272
}
277273
} else
278274
warn(tr("File '%1' cannot be read.").arg(url));

src/webots/nodes/WbTransform.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ bool WbTransform::isAValidBoundingObject(bool checkOde, bool warning) const {
326326
return false;
327327
}
328328

329-
if (g->isAValidBoundingObject(checkOde, warning) == false)
329+
if (!g->isPostFinalizedCalled() || !g->isAValidBoundingObject(checkOde, warning))
330330
return false;
331331

332332
if (checkOde && g->odeGeom() == NULL)

src/webots/nodes/WbTriangleMeshGeometry.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,7 @@ bool WbTriangleMeshGeometry::isSuitableForInsertionInBoundingObject(bool warning
361361
}
362362

363363
bool WbTriangleMeshGeometry::isAValidBoundingObject(bool checkOde, bool warning) const {
364+
assert(mTriangleMesh);
364365
return mTriangleMesh->isValid() && WbGeometry::isAValidBoundingObject(checkOde, warning);
365366
}
366367
/////////////////

0 commit comments

Comments
 (0)