Fix

Author: MNikoliCC

resources/projects/libraries/qt_utils/motion_editor/AddStateDialog.cpp

@@ -32,7 +32,7 @@ AddStateDialog::AddStateDialog(Motion *motion, QWidget *parent) : QDialog(parent
   populateListWidget();
 
   QWidget *buttonsWidget = new QWidget(this);
-  const QPushButton *const cancelButton = new QPushButton(tr("Cancel"), buttonsWidget);
+  const QPushButton *cancelButton = new QPushButton(tr("Cancel"), buttonsWidget);
   QPushButton *okButton = new QPushButton(tr("Ok"), buttonsWidget);
   QHBoxLayout *hBoxLayout = new QHBoxLayout(buttonsWidget);
   hBoxLayout->addStretch();

resources/projects/libraries/qt_utils/motion_editor/PoseEditor.cpp

@@ -36,7 +36,7 @@ PoseEditor::PoseEditor(Pose *pose, Pose *previousPose, Pose *nextPose, bool fixe
   formLayout->addRow(tr("&Milliseconds:"), mMilliSecondsSpinBox);
 
   QWidget *buttonsWidget = new QWidget(this);
-  const QPushButton *const cancelButton = new QPushButton(tr("Cancel"), buttonsWidget);
+  const QPushButton *cancelButton = new QPushButton(tr("Cancel"), buttonsWidget);
   QPushButton *okButton = new QPushButton(tr("Ok"), buttonsWidget);
   QHBoxLayout *hBoxLayout = new QHBoxLayout(buttonsWidget);
   hBoxLayout->addStretch();

src/webots/control/WbControlledWorld.cpp

@@ -46,7 +46,7 @@ WbControlledWorld::WbControlledWorld(WbTokenizer *tokenizer) :
     return;
 
   mNeedToYield = false;
-  foreach (const WbRobot *robot, robots())
+  foreach (const WbRobot *const robot, robots())
     connect(robot, &WbRobot::startControllerRequest, this, &WbControlledWorld::startController);
 }
 
@@ -195,7 +195,7 @@ void WbControlledWorld::checkIfReadRequestCompleted() {
 
 void WbControlledWorld::step() {
   if (mFirstStep && !mRetryEnabled) {
-    foreach (const WbRobot *robot, robots()) {
+    foreach (const WbRobot *const robot, robots()) {
       if (!robot->isControllerStarted())
         startController(robot);
     }

src/webots/engine/WbSimulationWorld.cpp

@@ -226,7 +226,7 @@ void WbSimulationWorld::step() {
     dImmersionOutlineDestroy(mImmersionGeoms.at(i).outline);
   mImmersionGeoms.clear();
 
-  foreach (const WbRobot *robot, robots()) {
+  foreach (const WbRobot *const robot, robots()) {
     if (robots().contains(robot))  // the 'processImmediateMessages' of another robot may have removed/regenerated this robot
       robot->processImmediateMessages();
   }
@@ -400,7 +400,7 @@ void WbSimulationWorld::reset(bool restartControllers) {
   dImmersionLinkGroupEmpty(mCluster->immersionLinkGroup());
   WbSoundEngine::stopAllSources();
   if (restartControllers) {
-    foreach (const WbRobot *robot, robots()) {
+    foreach (const WbRobot *const robot, robots()) {
       if (robot->isControllerStarted())
         robot->restartController();
     }

src/webots/gui/WbView3D.cpp

@@ -1813,7 +1813,7 @@ void WbView3D::mouseMoveEvent(QMouseEvent *event) {
   // Drag overlay even if modifier keys are pressed
   WbRenderingDevice *const renderingDevice = WbRenderingDevice::fromMousePosition(position.x(), position.y());
   if (renderingDevice) {
-    const WbWrenTextureOverlay *overlay = renderingDevice->overlay();
+    const WbWrenTextureOverlay *const overlay = renderingDevice->overlay();
     if (overlay) {
       overlay->putOnTop();
       if (overlay->isInsideResizeArea(position.x(), position.y()))

src/webots/nodes/WbRobot.cpp

@@ -331,7 +331,7 @@ void WbRobot::addDevices(WbNode *node) {
     const WbJoint *const joint = dynamic_cast<WbJoint *>(basicJoint);
     if (joint) {
       const QVector<WbLogicalDevice *> &jointDevices = joint->devices();
-      foreach (const WbLogicalDevice *jointDevice, jointDevices) {
+      foreach (const WbLogicalDevice *const jointDevice, jointDevices) {
         if (jointDevice == NULL)
           continue;
         mDevices.append(jointDevice);
@@ -344,9 +344,9 @@ void WbRobot::addDevices(WbNode *node) {
     return;
   }
 
-  const WbPropeller *propeller = dynamic_cast<const WbPropeller *>(node);
+  const WbPropeller *const propeller = dynamic_cast<const WbPropeller *>(node);
   if (propeller) {
-    const WbLogicalDevice *propellerDevice = propeller->device();
+    const WbLogicalDevice *const propellerDevice = propeller->device();
     if (propellerDevice) {
       mDevices.append(propellerDevice);
       connect(static_cast<WbBaseNode *>(propellerDevice), &WbBaseNode::destroyed, this, &WbRobot::updateDevicesAfterDestruction,

src/webots/nodes/WbSolid.cpp

@@ -1580,7 +1580,7 @@ void WbSolid::updateChildren() {
     connect(solid, &WbSolid::destroyed, this, &WbSolid::refreshPhysicsRepresentation, Qt::UniqueConnection);
     connect(solid, &WbSolid::physicsPropertiesChanged, this, &WbSolid::refreshPhysicsRepresentation, Qt::UniqueConnection);
   }
-  foreach (const WbBasicJoint *jointChild, mJointChildren)
+  foreach (const WbBasicJoint *const jointChild, mJointChildren)
     connect(jointChild, &WbBasicJoint::endPointChanged, this, &WbSolid::updateChildrenAfterJointEndPointChange,
             Qt::UniqueConnection);
 }

src/webots/nodes/WbTrack.cpp

@@ -951,7 +951,7 @@ void WbTrack::exportNodeSubNodes(WbWriter &writer) const {
   // write animated geometries
   if (!writer.isW3d() && !writer.isUrdf() && !isEmpty)
     writer << "\n";
-  isEmpty |= mAnimatedObjectList.isEmpty();
+  isEmpty = isEmpty || mAnimatedObjectList.isEmpty();
 
   exportAnimatedGeometriesMesh(writer);
 

src/webots/nodes/utils/WbNodeOperations.cpp

@@ -309,7 +309,9 @@ bool WbNodeOperations::deleteNode(WbNode *node, bool fromSupervisor) {
 
   setFromSupervisor(fromSupervisor);
 
-  WbWorld::instance()->awake();
+  const WbSolid *solidNode = dynamic_cast<WbSolid *>(node);
+  if (solidNode)
+    WbWorld::instance()->awake();
 
   const bool dictionaryNeedsUpdate = WbVrmlNodeUtilities::hasAreferredDefNodeDescendant(node);
   WbField *parentField = node->parentField();

src/webots/scene_tree/WbSceneTree.cpp

@@ -1125,7 +1125,7 @@ void WbSceneTree::updateSelection() {
     // quitting Webots
     return;
 
-  WbNodeOperations *const nodeOperations = WbNodeOperations::instance();
+  const WbNodeOperations *nodeOperations = WbNodeOperations::instance();
   if (nodeOperations->isFromSupervisor())
     // do not update selection if change come from supervisor
     return;