Skip to content

Commit d9f6f7b

Browse files
authored
Fix-to-include-system-openal (#6640)
* Make openal-dev a compilation dependency. * Include system openal lib in webots instead of downloading from cyberbotics. * Remove OPENAL_INCLUDE from Makefile because it should be in the system include path.
1 parent 3ec6560 commit d9f6f7b

File tree

3 files changed

+7
-18
lines changed

3 files changed

+7
-18
lines changed

dependencies/Makefile.linux

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ DEPENDENCIES_URL = https://cyberbotics.com/files/repository/dependencies/linux64
88

99
QT_VERSION = 6.5.3
1010
QT_PACKAGE = webots-qt-$(QT_VERSION)-linux64-release.tar.bz2
11-
OPENAL_PACKAGE = openal-linux64-1.16.0.tar.bz2
1211
OIS_PACKAGE = libOIS.1.4.tar.bz2
1312
ASSIMP_PACKAGE = libassimp-5.2.3.tar.bz2
1413
PICO_PACKAGE = libpico.tar.bz2
@@ -58,22 +57,13 @@ $(WEBOTS_DEPENDENCY_PATH)/$(QT_PACKAGE):
5857

5958

6059
open-al-clean:
61-
@rm -rf $(WEBOTS_DEPENDENCY_PATH)/openal $(WEBOTS_DEPENDENCY_PATH)/$(OPENAL_PACKAGE)* $(WEBOTS_HOME_LIB)/libopenal.so*
60+
@rm -rf $(WEBOTS_HOME_LIB)/libopenal.so*
6261

6362
open-al: $(WEBOTS_HOME_LIB)/libopenal.so
6463

65-
$(WEBOTS_HOME_LIB)/libopenal.so: $(WEBOTS_DEPENDENCY_PATH)/openal
66-
@cp -a $(WEBOTS_DEPENDENCY_PATH)/openal/build/libopenal.so* $(WEBOTS_HOME_LIB)/
67-
68-
$(WEBOTS_DEPENDENCY_PATH)/openal:
69-
@echo "# downloading $(OPENAL_PACKAGE)"
70-
@rm -f $(WEBOTS_DEPENDENCY_PATH)/$(OPENAL_PACKAGE)
71-
@wget -qq $(DEPENDENCIES_URL)/$(OPENAL_PACKAGE) -P $(WEBOTS_DEPENDENCY_PATH)
72-
@if [ "$$(md5sum $(OPENAL_PACKAGE) | awk '{print $$1;}')" != "6c7c9a77dec67f42c51d0f035a94a090" ]; then echo "MD5 checksum failed for $(OPENAL_PACKAGE)"; exit 1; fi
73-
@echo "# uncompressing $(OPENAL_PACKAGE)"
74-
@tar xfm $(WEBOTS_DEPENDENCY_PATH)/$(OPENAL_PACKAGE) -C $(WEBOTS_DEPENDENCY_PATH)
75-
@rm -f $(WEBOTS_DEPENDENCY_PATH)/$(OPENAL_PACKAGE)
76-
64+
.LIBPATTERNS = lib%.so lib%.so.1 lib%.a
65+
$(WEBOTS_HOME_LIB)/libopenal.so: -lopenal
66+
@cp -a $<* $(WEBOTS_HOME_LIB)/
7767

7868
ois-clean:
7969
@rm -rf $(WEBOTS_DEPENDENCY_PATH)/$(OIS_PACKAGE) $(WEBOTS_HOME_LIB)/libOIS* $(WEBOTS_HOME)/include/libOIS

scripts/install/linux_compilation_dependencies.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ fi
1212

1313
alias apt='apt --option="APT::Acquire::Retries=3"'
1414
apt update
15-
apt install --yes git lsb-release cmake swig libglu1-mesa-dev libglib2.0-dev libfreeimage3 libfreetype6-dev libxml2-dev libboost-dev libssh-gcrypt-dev libzip-dev libreadline-dev pbzip2 wget zip unzip python3 python3-pip
15+
apt install --yes git lsb-release cmake swig libglu1-mesa-dev libglib2.0-dev libfreeimage3 libfreetype6-dev libxml2-dev libboost-dev libssh-gcrypt-dev libzip-dev libreadline-dev pbzip2 wget zip unzip python3 python3-pip libopenal-dev
1616

1717
UBUNTU_VERSION=$(lsb_release -rs)
1818
if [[ $UBUNTU_VERSION == "20.04" ]]; then

src/webots/Makefile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ WB_CONTROL_INCLUDE = $(QT_CORE_INCLUDE) $(QT_NETWORK_INCLUDE) -Icore -Ieng
4444
WB_NODES_INCLUDE = $(QT_CORE_INCLUDE) $(QT_NETWORK_INCLUDE) $(QT_GUI_INCLUDE) $(ODE_INCLUDE) $(CONTROLLER_INCLUDE) $(OIS_INCLUDE) $(FREETYPE_INCLUDE) $(WREN_INCLUDE) $(STB_INCLUDE) $(ASSIMP_INCLUDE) -Iapp -Icore -isystem external/siphash -Imaths -Inodes -Inodes/utils -Iode -Iplugins -Isound -Iutil -Ivrml
4545
WB_APP_INCLUDE = $(QT_CORE_INCLUDE) $(QT_NETWORK_INCLUDE) $(ODE_INCLUDE) $(WREN_INCLUDE) -Icontrol -Icore -Ieditor -Iengine -Imaths -Inodes -Inodes/utils -Iplugins -Iscene_tree -Ivrml
4646
WB_SCENE_TREE_INCLUDE = $(QT_CORE_INCLUDE) $(QT_GUI_INCLUDE) $(QT_WIDGETS_INCLUDE) $(ASSIMP_INCLUDE) -isystem external/siphash -Iapp -Icore -Ieditor -Imaths -Inodes -Inodes/utils -Iode -Iuser_commands -Ivrml -Iwidgets
47-
WB_SOUND_INCLUDE = $(QT_CORE_INCLUDE) $(QT_XML_INCLUDE) $(ODE_INCLUDE) $(OPENAL_INCLUDE) $(PICO_INCLUDE) -Icore -Imaths -Inodes -Inodes/utils -Isound -Ivrml
47+
WB_SOUND_INCLUDE = $(QT_CORE_INCLUDE) $(QT_XML_INCLUDE) $(ODE_INCLUDE) $(PICO_INCLUDE) -Icore -Imaths -Inodes -Inodes/utils -Isound -Ivrml
4848
WB_GUI_INCLUDE = $(QT_CORE_INCLUDE) $(QT_NETWORK_INCLUDE) $(QT_WEBSOCKETS_INCLUDE) $(QT_GUI_INCLUDE) $(QT_WIDGETS_INCLUDE) $(QT_OPENGL_INCLUDE) $(QT_OPENGL_WIDGETS_INCLUDE) $(ODE_INCLUDE) $(WREN_INCLUDE) -Iapp -Icontrol -Icore -Iwidgets -Ieditor -Iengine -isystem external/siphash -Imaths -Inodes -Inodes/utils -Iplugins -Iscene_tree -Isound -Iuser_commands -Iutil -Ivrml
4949
WB_RENDER_INCLUDE = $(QT_CORE_INCLUDE) $(QT_GUI_INCLUDE) $(QT_OPENGL_INCLUDE) $(QT_WIDGETS_INCLUDE) $(WREN_INCLUDE) -isystem external/siphash
5050

@@ -104,7 +104,6 @@ CFLAGS += -Wno-deprecated-register
104104

105105
else ifeq ($(OSTYPE),linux)
106106
LIB_WREN = ../wren/libwren.a ../glad/libglad.a
107-
OPENAL_INCLUDE = -I$(WEBOTS_DEPENDENCY_PATH)/openal/include
108107
ASSIMP_INCLUDE = -I$(WEBOTS_PATH)/include/libassimp/include
109108
QT_CORE_INCLUDE = -isystem $(WEBOTS_PATH)/include/qt/QtCore
110109
QT_GUI_INCLUDE = -isystem $(WEBOTS_PATH)/include/qt/QtGui
@@ -182,7 +181,7 @@ CONTROLLER_INCLUDE = -I$(WEBOTS_PATH)/include/controller/c
182181
ODE_INCLUDE = -Iode -isystem $(WEBOTS_PATH)/include/ode
183182
QT_CORE_INCLUDE += -I$(OBJDIR)
184183
WREN_INCLUDE += -Iwren
185-
INCLUDE = $(ALL_INCLUDE) $(CONTROLLER_INCLUDE) $(ODE_INCLUDE) $(QT_CORE_INCLUDE) $(QT_GUI_INCLUDE) $(QT_WIDGETS_INCLUDE) $(QT_PRINT_SUPPORT_INCLUDE) $(QT_OPENGL_INCLUDE) $(QT_NETWORK_INCLUDE) $(LUA_INCLUDE) $(OIS_INCLUDE) $(OPENAL_INCLUDE) $(PICO_INCLUDE) $(WREN_INCLUDE) $(FREETYPE_INCLUDE) $(STB_INCLUDE) $(ASSIMP_INCLUDE)
184+
INCLUDE = $(ALL_INCLUDE) $(CONTROLLER_INCLUDE) $(ODE_INCLUDE) $(QT_CORE_INCLUDE) $(QT_GUI_INCLUDE) $(QT_WIDGETS_INCLUDE) $(QT_PRINT_SUPPORT_INCLUDE) $(QT_OPENGL_INCLUDE) $(QT_NETWORK_INCLUDE) $(LUA_INCLUDE) $(OIS_INCLUDE) $(PICO_INCLUDE) $(WREN_INCLUDE) $(FREETYPE_INCLUDE) $(STB_INCLUDE) $(ASSIMP_INCLUDE)
186185

187186
ifeq ($(MAKECMDGOALS),debug)
188187
CFLAGS += -ggdb

0 commit comments

Comments
 (0)