Fix scrutinizer issues (#21)

* Fix scrutinizer issues

* Remove return from __construct method

Author: antonkomarev

.scrutinizer.yml

@@ -6,3 +6,5 @@ coding_style:
     spaces:
       before_parentheses:
         closure_definition: true
+      around_operators:
+        concatenation: true

src/Http/Controllers/Api/Jobs/Collect/Response.php

@@ -15,7 +15,6 @@
 
 use Illuminate\Contracts\Support\Responsable as ResponsableContract;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
 
 final class Response implements ResponsableContract
 {
@@ -34,10 +33,10 @@ public function __construct(iterable $jobs)
      */
     public function toResponse($request)
     {
-        return $this->toJson($request);
+        return $this->toJson();
     }
 
-    private function toJson(Request $request): JsonResponse
+    private function toJson(): JsonResponse
     {
         $jobs = [];
         foreach ($this->jobs as $job) {

src/Http/Controllers/Api/Jobs/Get/Response.php

@@ -16,7 +16,6 @@
 use Cog\Contracts\Paket\Job\Entities\Job as JobContract;
 use Illuminate\Contracts\Support\Responsable as ResponsableContract;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
 
 final class Response implements ResponsableContract
 {
@@ -35,10 +34,10 @@ public function __construct(JobContract $job)
      */
     public function toResponse($request)
     {
-        return $this->toJson($request);
+        return $this->toJson();
     }
 
-    private function toJson(Request $request): JsonResponse
+    private function toJson(): JsonResponse
     {
         return response()->json($this->job->toArray());
     }

src/Http/Controllers/Api/Jobs/Post/Response.php

@@ -16,7 +16,6 @@
 use Cog\Contracts\Paket\Job\Entities\Job as JobContract;
 use Illuminate\Contracts\Support\Responsable as ResponsableContract;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
 
 final class Response implements ResponsableContract
 {
@@ -35,10 +34,10 @@ public function __construct(JobContract $job)
      */
     public function toResponse($request)
     {
-        return $this->toJson($request);
+        return $this->toJson();
     }
 
-    private function toJson(Request $request): JsonResponse
+    private function toJson(): JsonResponse
     {
         return response()->json($this->job->toArray(), 201);
     }

src/Http/Controllers/Api/Requirements/Collect/Response.php

@@ -15,7 +15,6 @@
 
 use Illuminate\Contracts\Support\Responsable as ResponsableContract;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
 
 final class Response implements ResponsableContract
 {
@@ -34,10 +33,10 @@ public function __construct(iterable $requirements)
      */
     public function toResponse($request)
     {
-        return $this->toJson($request);
+        return $this->toJson();
     }
 
-    private function toJson(Request $request): JsonResponse
+    private function toJson(): JsonResponse
     {
         return response()->json($this->requirements);
     }

src/Http/Controllers/App/Response.php

@@ -14,7 +14,6 @@
 namespace Cog\Laravel\Paket\Http\Controllers\App;
 
 use Illuminate\Contracts\Support\Responsable as ResponsableContract;
-use Illuminate\Http\Request;
 use Illuminate\Http\Response as IlluminateResponse;
 use Illuminate\Support\Facades\Config;
 
@@ -28,10 +27,10 @@ final class Response implements ResponsableContract
      */
     public function toResponse($request)
     {
-        return $this->toHtml($request);
+        return $this->toHtml();
     }
 
-    private function toHtml(Request $request): IlluminateResponse
+    private function toHtml(): IlluminateResponse
     {
         return response()->view('paket::app', [
             'cssFile' => 'app.css',

src/Support/Composer.php

@@ -50,7 +50,6 @@ final class Composer
      * @param \Illuminate\Filesystem\Filesystem $files
      * @param string $workingPath
      * @param string $loggingPath
-     * @return void
      */
     public function __construct(Filesystem $files, string $workingPath, string $loggingPath)
     {