Fixes

Author: cyberjunky

.gitignore

@@ -144,4 +144,4 @@ dmypy.json
 .pyre/
 
 # Ignore folder for local testing
-ignore/
+ignore/

.pre-commit-config.yaml

@@ -18,11 +18,31 @@ repos:
       - tomli
     exclude: 'cassettes/'
 
+- repo: https://github.com/psf/black
+  rev: 24.8.0
+  hooks:
+  - id: black
+    additional_dependencies: ['.[jupyter]']
+    language_version: python3
+
+- repo: https://github.com/astral-sh/ruff-pre-commit
+  rev: v0.6.4
+  hooks:
+  - id: ruff
+    args: [--fix]
+  - id: ruff-format
+
 - repo: local
   hooks:
+  - id: format
+    name: format
+    entry: .venv/bin/pdm run format
+    types: [python]
+    language: system
+    pass_filenames: false
   - id: lint
     name: lint
-    entry: pdm run lint
+    entry: .venv/bin/pdm run lint
     types: [python]
     language: system
     pass_filenames: false

.vscode/settings.json

@@ -4,4 +4,4 @@
     ],
     "python.testing.unittestEnabled": false,
     "python.testing.pytestEnabled": true
-}
+}

README.md

@@ -9,7 +9,7 @@ $ ./example.py
 Select a category:
 
   [1] 👤 User & Profile
-  [2] 📊 Daily Health & Activity  
+  [2] 📊 Daily Health & Activity
   [3] 🔬 Advanced Health Metrics
   [4] 📈 Historical Data & Trends
   [5] 🏃 Activities & Workouts
@@ -22,7 +22,7 @@ Select a category:
 
   [q] Exit program
 
-Make your selection: 
+Make your selection:
 ```
 
 ### API Coverage Statistics
@@ -59,7 +59,7 @@ A comprehensive Python 3 API wrapper for Garmin Connect, providing access to hea
 This library enables developers to programmatically access Garmin Connect data including:
 
 - **Health Metrics**: Heart rate, sleep, stress, body composition, SpO2, HRV
-- **Activity Data**: Workouts, exercises, training status, performance metrics  
+- **Activity Data**: Workouts, exercises, training status, performance metrics
 - **Device Information**: Connected devices, settings, alarms, solar data
 - **Goals & Achievements**: Personal records, badges, challenges, race predictions
 - **Historical Data**: Trends, progress tracking, date range queries
@@ -146,7 +146,7 @@ pdm run --list     # Display all available PDM scripts
 # Before making changes
 pdm run lint       # Check current code quality
 
-# After making changes  
+# After making changes
 pdm run format     # Auto-format your code
 pdm run lint       # Verify code quality
 pdm run codespell  # Check spelling
@@ -161,7 +161,7 @@ The library uses the same OAuth authentication as the official Garmin Connect ap
 
 **Key Features:**
 - Login credentials valid for one year (no repeated logins)
-- Secure OAuth token storage 
+- Secure OAuth token storage
 - Same authentication flow as official app
 
 **Advanced Configuration:**
@@ -195,7 +195,7 @@ pdm run testcov     # Run tests with coverage report
 
 **Note:** Tests automatically use `~/.garminconnect` as the default token file location. You can override this by setting the `GARMINTOKENS` environment variable. Run `example.py` first to generate authentication tokens for testing.
 
-**For Developers:** Tests use VCR cassettes to record/replay HTTP interactions. If tests fail with authentication errors, ensure valid tokens exist in `~/.garminconnect` 
+**For Developers:** Tests use VCR cassettes to record/replay HTTP interactions. If tests fail with authentication errors, ensure valid tokens exist in `~/.garminconnect`
 
 ## 📦 Publishing
 
@@ -232,13 +232,13 @@ pdm publish        # Publish pre-built package
 We welcome contributions! Here's how you can help:
 
 - **Report Issues**: Bug reports and feature requests via GitHub issues
-- **Submit PRs**: Code improvements, new features, documentation updates  
+- **Submit PRs**: Code improvements, new features, documentation updates
 - **Testing**: Help test new features and report compatibility issues
 - **Documentation**: Improve examples, add use cases, fix typos
 
 **Before Contributing:**
 1. Set up development environment (`pdm install --group :all`)
-2. Execute code quality checks (`pdm run format && pdm run lint`) 
+2. Execute code quality checks (`pdm run format && pdm run lint`)
 3. Test your changes (`pdm run test`)
 4. Follow existing code style and patterns
 
@@ -255,7 +255,7 @@ pdm install --group :all
 
 # 3. Quality checks
 pdm run format     # Auto-format code
-pdm run lint       # Check code quality  
+pdm run lint       # Check code quality
 pdm run test       # Run tests
 
 # 4. Submit PR
@@ -293,7 +293,7 @@ print(f"Resting HR: {hr_data['restingHeartRate']}")
 Special thanks to all contributors who have helped improve this project:
 
 - **Community Contributors**: Bug reports, feature requests, and code improvements
-- **Issue Reporters**: Helping identify and resolve compatibility issues  
+- **Issue Reporters**: Helping identify and resolve compatibility issues
 - **Feature Developers**: Adding new API endpoints and functionality
 - **Documentation Authors**: Improving examples and user guides
 
@@ -307,7 +307,7 @@ If you find this library useful for your projects, please consider supporting it
 
 - **⭐ Star this repository** - Help others discover the project
 - **💰 Financial Support** - Contribute to development and hosting costs
-- **🐛 Report Issues** - Help improve stability and compatibility  
+- **🐛 Report Issues** - Help improve stability and compatibility
 - **📖 Spread the Word** - Share with other developers
 
 ### 💳 Financial Support Options

garminconnect/__init__.py

@@ -537,8 +537,13 @@ def get_body_composition(
         """
 
         startdate = _validate_date_format(startdate, "startdate")
-        enddate = startdate if enddate is None else _validate_date_format(enddate, "enddate")
-        if datetime.strptime(startdate, DATE_FORMAT_STR).date() > datetime.strptime(enddate, DATE_FORMAT_STR).date():
+        enddate = (
+            startdate if enddate is None else _validate_date_format(enddate, "enddate")
+        )
+        if (
+            datetime.strptime(startdate, DATE_FORMAT_STR).date()
+            > datetime.strptime(enddate, DATE_FORMAT_STR).date()
+        ):
             raise ValueError("Startdate cannot be after enddate")
         url = f"{self.garmin_connect_weight_url}/weight/dateRange"
         params = {"startDate": str(startdate), "endDate": str(enddate)}
@@ -838,7 +843,6 @@ def get_lactate_threshold(
         """
 
         if latest:
-
             speed_and_heart_rate_url = (
                 f"{self.garmin_connect_biometric_url}/latestLactateThreshold"
             )
@@ -1862,7 +1866,6 @@ def get_activity_details(
     def get_activity_exercise_sets(self, activity_id: str) -> dict[str, Any]:
         """Return activity exercise sets."""
 
-        activity_id = _validate_positive_integer(activity_id, "activity_id")
         url = f"{self.garmin_connect_activity}/{activity_id}/exerciseSets"
         logger.debug("Requesting exercise sets for activity id %s", activity_id)
 
@@ -1871,7 +1874,6 @@ def get_activity_exercise_sets(self, activity_id: str) -> dict[str, Any]:
     def get_activity_gear(self, activity_id: str) -> dict[str, Any]:
         """Return gears used for activity id."""
 
-        activity_id = _validate_positive_integer(activity_id, "activity_id")
         params = {
             "activityId": str(activity_id),
         }
@@ -1934,14 +1936,12 @@ def get_workouts(self, start: int = 0, limit: int = 100) -> dict[str, Any]:
     def get_workout_by_id(self, workout_id: str) -> dict[str, Any]:
         """Return workout by id."""
 
-        workout_id = _validate_positive_integer(workout_id, "workout_id")
         url = f"{self.garmin_workouts}/workout/{workout_id}"
         return self.connectapi(url)
 
     def download_workout(self, workout_id: str) -> bytes:
         """Download workout by id."""
 
-        workout_id = _validate_positive_integer(workout_id, "workout_id")
         url = f"{self.garmin_workouts}/workout/FIT/{workout_id}"
         logger.debug("Downloading workout from %s", url)
 

pyproject.toml

@@ -92,7 +92,7 @@ line-length = 88
 target-version = "py310"
 exclude = [
     ".git",
-    ".venv", 
+    ".venv",
     "__pycache__",
     ".pytest_cache",
     "build",
@@ -151,6 +151,12 @@ testcov = {composite = ["test", "pdm run coverage html", "pdm run coverage xml -
 codespell = "pre-commit run codespell --all-files"
 clean = "python -c \"import shutil, pathlib; [shutil.rmtree(p, ignore_errors=True) for p in pathlib.Path('.').rglob('__pycache__')]; [p.unlink(missing_ok=True) for p in pathlib.Path('.').rglob('*.py[co]')]\""
 
+# Pre-commit hooks
+pre-commit-install = "pre-commit install"
+pre-commit-run = "pre-commit run --all-files"
+pre-commit-run-staged = "pre-commit run"
+pre-commit-update = "pre-commit autoupdate"
+
 # Publishing
 build = "pdm build"
 publish = {composite = ["build", "pdm publish"]}
@@ -160,8 +166,8 @@ record-vcr = {env = {GARMINTOKENS = "~/.garminconnect"}, cmd = "pdm run pytest t
 clean-vcr = "rm -f tests/cassettes/*.yaml"
 reset-vcr = {composite = ["clean-vcr", "record-vcr"]}
 
-# Quality checks  
-all = {composite = ["lint", "codespell", "test"]}
+# Quality checks
+all = {composite = ["lint", "codespell", "pre-commit-run", "test"]}
 
 [tool.pdm.dev-dependencies]
 dev = [