Skip to content

Commit 21c861e

Browse files
committed
[*] move log to another form, closes #26
1 parent fc7cca8 commit 21c861e

File tree

9 files changed

+105
-39
lines changed

9 files changed

+105
-39
lines changed

forms/fmconnect.pas

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
unit fmConnect;
22

3-
{$MODE Delphi}
3+
{$mode objfpc}{$H+}
44

55
interface
66

@@ -39,9 +39,6 @@ TfmConnect = class(TForm)
3939

4040
function EditDatabase(ADatabase: TPQConnection): boolean;
4141

42-
var
43-
fmConnect: TfmConnect;
44-
4542
implementation
4643

4744
{$R *.lfm}

forms/fmlog.lfm

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
object fmLog: TfmLog
2+
Left = 554
3+
Height = 856
4+
Top = 176
5+
Width = 935
6+
Caption = 'Log'
7+
ClientHeight = 856
8+
ClientWidth = 935
9+
DesignTimePPI = 144
10+
LCLVersion = '2.0.12.0'
11+
object mmLog: TMemo
12+
Left = 4
13+
Height = 848
14+
Top = 4
15+
Width = 927
16+
Align = alClient
17+
BorderSpacing.Left = 2
18+
BorderSpacing.Top = 2
19+
BorderSpacing.Right = 2
20+
BorderSpacing.Bottom = 2
21+
BorderSpacing.Around = 2
22+
BorderSpacing.InnerBorder = 2
23+
Font.Name = 'Consolas'
24+
ParentFont = False
25+
ScrollBars = ssVertical
26+
TabOrder = 0
27+
end
28+
end

forms/fmlog.pas

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
unit fmLog;
2+
3+
{$mode objfpc}{$H+}
4+
5+
interface
6+
7+
uses
8+
Classes, SysUtils, Forms, Controls, Graphics, Dialogs, StdCtrls;
9+
10+
type
11+
12+
{ TfmLog }
13+
14+
TfmLog = class(TForm)
15+
mmLog: TMemo;
16+
private
17+
18+
public
19+
20+
end;
21+
22+
var
23+
LogForm: TfmLog;
24+
25+
implementation
26+
27+
{$R *.lfm}
28+
29+
end.
30+

forms/fmmain.lfm

Lines changed: 10 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ object fmMain: TfmMain
2323
TabOrder = 1
2424
object gridTasks: TDBGrid
2525
Left = 2
26-
Height = 222
26+
Height = 531
2727
Top = 42
2828
Width = 1508
2929
Align = alClient
@@ -107,25 +107,6 @@ object fmMain: TfmMain
107107
OnDrawColumnCell = gridTasksDrawColumnCell
108108
OnSelectEditor = gridTasksSelectEditor
109109
end
110-
object splitDetails: TSplitter
111-
Cursor = crVSplit
112-
Left = 2
113-
Height = 9
114-
Top = 264
115-
Width = 1508
116-
Align = alBottom
117-
ResizeAnchor = akBottom
118-
end
119-
object mmLog: TMemo
120-
Left = 2
121-
Height = 300
122-
Top = 273
123-
Width = 1508
124-
Align = alBottom
125-
ParentFont = False
126-
ScrollBars = ssAutoVertical
127-
TabOrder = 2
128-
end
129110
object toolbarTasks: TToolBar
130111
Left = 2
131112
Height = 40
@@ -139,7 +120,7 @@ object fmMain: TfmMain
139120
Images = imglToolbars
140121
ParentShowHint = False
141122
ShowHint = True
142-
TabOrder = 3
123+
TabOrder = 1
143124
object btnTaskMoveUp: TToolButton
144125
Left = 1
145126
Top = 0
@@ -758,6 +739,14 @@ object fmMain: TfmMain
758739
OnClick = miCloseClick
759740
end
760741
end
742+
object miView: TMenuItem
743+
Caption = 'View'
744+
object miLog: TMenuItem
745+
AutoCheck = True
746+
Caption = 'Log'
747+
OnClick = miLogClick
748+
end
749+
end
761750
object miHelp: TMenuItem
762751
Caption = 'Help'
763752
object miAbout: TMenuItem

forms/fmmain.pas

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ TfmMain = class(TForm)
3535
imglToolbarsDisabled: TImageList;
3636
imglToolbars: TImageList;
3737
imglGrids: TImageList;
38+
miLog: TMenuItem;
39+
miView: TMenuItem;
3840
miConnect: TMenuItem;
39-
mmLog: TMemo;
4041
menuMain: TMainMenu;
4142
miFile: TMenuItem;
4243
miClose: TMenuItem;
@@ -46,7 +47,6 @@ TfmMain = class(TForm)
4647
pnlChains: TPanel;
4748
pnlDetails: TPanel;
4849
splitChain: TSplitter;
49-
splitDetails: TSplitter;
5050
toolbarChains: TToolBar;
5151
toolbarMain: TToolBar;
5252
btnConnect: TToolButton;
@@ -90,6 +90,7 @@ TfmMain = class(TForm)
9090
procedure gridTasksSelectEditor(Sender: TObject; Column: TColumn;
9191
var Editor: TWinControl);
9292
procedure miCloseClick(Sender: TObject);
93+
procedure miLogClick(Sender: TObject);
9394
private
9495
FLastColumn: TColumn; //last sorted grid column
9596
public
@@ -101,7 +102,7 @@ TfmMain = class(TForm)
101102

102103
implementation
103104

104-
uses uDataModule, SQLDB, LCLType, RegExpr;
105+
uses uDataModule, SQLDB, LCLType, RegExpr, fmLog;
105106

106107
{$R *.lfm}
107108

@@ -214,6 +215,11 @@ procedure TfmMain.miCloseClick(Sender: TObject);
214215
Close();
215216
end;
216217

218+
procedure TfmMain.miLogClick(Sender: TObject);
219+
begin
220+
fmLog.LogForm.Visible := not fmLog.LogForm.Visible;
221+
end;
222+
217223
procedure TfmMain.UpdateSortIndication(ACol: TColumn);
218224
begin
219225
// Remove the sort arrow from the previous column we sorted
@@ -352,7 +358,7 @@ procedure TfmMain.acConnectClick(Sender: TObject);
352358
dmPgEngine.Connect;
353359
except
354360
on EAbort do
355-
mmLog.Lines.Append('Connection cancelled by the user');
361+
fmLog.LogForm.mmLog.Lines.Append('Connection cancelled by the user');
356362
on E: Exception do
357363
MessageDlg('PostgreSQL Error', E.Message, mtError, [mbOK], 0);
358364
end

pg_timetable_gui.lpi

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,18 +103,21 @@
103103
<FormatVersion Value="2"/>
104104
<Modes Count="0"/>
105105
</RunParams>
106-
<RequiredPackages Count="3">
106+
<RequiredPackages Count="4">
107107
<Item1>
108-
<PackageName Value="LazControls"/>
108+
<PackageName Value="SynEdit"/>
109109
</Item1>
110110
<Item2>
111-
<PackageName Value="FCL"/>
111+
<PackageName Value="LazControls"/>
112112
</Item2>
113113
<Item3>
114-
<PackageName Value="LCL"/>
114+
<PackageName Value="FCL"/>
115115
</Item3>
116+
<Item4>
117+
<PackageName Value="LCL"/>
118+
</Item4>
116119
</RequiredPackages>
117-
<Units Count="8">
120+
<Units Count="9">
118121
<Unit0>
119122
<Filename Value="pg_timetable_gui.lpr"/>
120123
<IsPartOfProject Value="True"/>
@@ -160,6 +163,14 @@
160163
<ResourceBaseClass Value="Form"/>
161164
<UnitName Value="fmConnect"/>
162165
</Unit7>
166+
<Unit8>
167+
<Filename Value="forms\fmlog.pas"/>
168+
<IsPartOfProject Value="True"/>
169+
<ComponentName Value="fmLog"/>
170+
<HasResources Value="True"/>
171+
<ResourceBaseClass Value="Form"/>
172+
<UnitName Value="fmLog"/>
173+
</Unit8>
163174
</Units>
164175
</ProjectOptions>
165176
<CompilerOptions>

pg_timetable_gui.lpr

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
lazcontrols,
99
fmMain, fmConnect,
1010
uDataModule,
11-
uObjects;
11+
uObjects, fmLog;
1212

1313
{$R *.res}
1414

@@ -18,5 +18,6 @@
1818
Application.Initialize;
1919
Application.CreateForm(TfmMain, MainForm);
2020
Application.CreateForm(TdmPgEngine, dmPgEngine);
21+
Application.CreateForm(TfmLog, LogForm);
2122
Application.Run;
2223
end.

udatamodule.lfm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ object dmPgEngine: TdmPgEngine
2020
Transaction = transChains
2121
UserName = 'scheduler'
2222
OnLog = PQConnLog
23-
LogEvents = [detParamValue, detActualSQL]
23+
LogEvents = [detPrepare, detExecute, detCommit, detParamValue, detActualSQL]
2424
Left = 105
2525
Top = 312
2626
end

udatamodule.pas

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,21 @@ TdmPgEngine = class(TDataModule)
4747

4848
implementation
4949

50-
uses uObjects, fmMain, fmConnect, Dialogs, UITypes;
50+
uses uObjects, fmMain, fmConnect, Dialogs, UITypes, fmLog;
5151

5252
{$R *.lfm}
5353

5454
{ TdmPgEngine }
5555

5656
procedure TdmPgEngine.PQConnLog(Sender: TSQLConnection;
5757
EventType: TDBEventType; const Msg: String);
58+
const et: array[TDBEventType] of string = ('detCustom', 'detPrepare', 'detExecute',
59+
'detFetch', 'detCommit', 'detRollBack', 'detParamValue', 'detActualSQL');
5860
begin
59-
fmMain.MainForm.mmLog.Lines.Append(Msg);
60-
fmMain.MainForm.mmLog.Lines.Append('----------------------------------------------------');
61+
with fmLog.LogForm.mmLog.Lines do
62+
begin
63+
Append(Format('[%s:] %s' + LineEnding, [et[EventType], Msg]))
64+
end;
6165
end;
6266

6367
procedure TdmPgEngine.PQConnLogin(Sender: TObject; Username, Password: string);

0 commit comments

Comments
 (0)