Skip to content

Commit 05aaa13

Browse files
authored
[-] fix dbSourcesReaderWriter.updateDatabase() to include is_enabled (#760)
1 parent 29ef983 commit 05aaa13

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

docker/demo/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ RUN apt-get update \
3434
&& sh /usr/share/postgresql-common/pgdg/apt.postgresql.org.sh -y \
3535
&& curl -L "https://www.postgresql.org/media/keys/ACCC4CF8.asc" | apt-key add - \
3636
&& curl -s https://packagecloud.io/install/repositories/timescale/timescaledb/script.deb.sh | bash \
37-
3837
&& apt-get -qy install \
3938
timescaledb-2-postgresql-17 postgresql-plpython3-17 postgresql-17-pg-qualstats \
4039
supervisor python3-psutil libfontconfig1 \

internal/sinks/prometheus.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,6 @@ func (promw *PrometheusWriter) Collect(ch chan<- prometheus.Metric) {
164164
ch <- promw.totalScrapeFailures
165165
promw.lastScrapeErrors.Set(lastScrapeErrors)
166166
ch <- promw.lastScrapeErrors
167-
168-
// atomic.StoreInt64(&lastSuccessfulDatastoreWriteTimeEpoch, time.Now().Unix())
169167
}
170168

171169
func (promw *PrometheusWriter) setInstanceUpDownState(ch chan<- prometheus.Metric, dbName string) {

internal/sources/postgres.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,10 @@ func (r *dbSourcesReaderWriter) updateDatabase(conn db.PgxIface, md Source) (err
6363
exclude_pattern,
6464
custom_tags,
6565
host_config,
66-
only_if_master)
66+
only_if_master,
67+
is_enabled)
6768
values
68-
($1, $2, $3, $4, $5, $6, NULLIF($7, ''), NULLIF($8, ''), $9, $10, $11, $12, $13)
69+
($1, $2, $3, $4, $5, $6, NULLIF($7, ''), NULLIF($8, ''), $9, $10, $11, $12, $13, $14)
6970
on conflict (name) do update set
7071
"group" = $2,
7172
dbtype = $3,
@@ -78,12 +79,13 @@ on conflict (name) do update set
7879
exclude_pattern = $10,
7980
custom_tags = $11,
8081
host_config = $12,
81-
only_if_master = $13`
82+
only_if_master = $13,
83+
is_enabled = $14`
8284
_, err = conn.Exec(context.Background(), sql,
8385
md.Name, md.Group, md.Kind,
8486
md.ConnStr, m(md.Metrics), m(md.MetricsStandby), md.PresetMetrics, md.PresetMetricsStandby,
8587
md.IncludePattern, md.ExcludePattern, m(md.CustomTags),
86-
m(md.HostConfig), md.OnlyIfMaster)
88+
m(md.HostConfig), md.OnlyIfMaster, md.IsEnabled)
8789
return err
8890
}
8991

internal/sources/postgres_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func TestUpdateDatabase(t *testing.T) {
128128
md.ConnStr, `{"metric":60}`, `{"standby_metric":60}`,
129129
md.PresetMetrics, md.PresetMetricsStandby,
130130
md.IncludePattern, md.ExcludePattern, `{"tag":"value"}`,
131-
nil, md.OnlyIfMaster,
131+
nil, md.OnlyIfMaster, md.IsEnabled,
132132
).WillReturnResult(pgxmock.NewResult("UPDATE", 1))
133133

134134
pgrw, err := sources.NewPostgresSourcesReaderWriterConn(ctx, conn)
@@ -167,7 +167,7 @@ func TestWriteMonitoredDatabases(t *testing.T) {
167167
md.Name, md.Group, md.Kind,
168168
md.ConnStr, `{"metric":60}`, `{"standby_metric":60}`, md.PresetMetrics, md.PresetMetricsStandby,
169169
md.IncludePattern, md.ExcludePattern, `{"tag":"value"}`,
170-
nil, md.OnlyIfMaster,
170+
nil, md.OnlyIfMaster, md.IsEnabled,
171171
).WillReturnResult(pgxmock.NewResult("INSERT", 1))
172172
conn.ExpectCommit()
173173
conn.ExpectRollback() // deferred rollback
@@ -203,7 +203,7 @@ func TestWriteMonitoredDatabases(t *testing.T) {
203203
md.Name, md.Group, md.Kind,
204204
md.ConnStr, `{"metric":60}`, `{"standby_metric":60}`, md.PresetMetrics, md.PresetMetricsStandby,
205205
md.IncludePattern, md.ExcludePattern, `{"tag":"value"}`,
206-
nil, md.OnlyIfMaster,
206+
nil, md.OnlyIfMaster, md.IsEnabled,
207207
).WillReturnError(errors.New("failed insert"))
208208
conn.ExpectRollback()
209209

0 commit comments

Comments
 (0)