[-] monitor all sources if --group cmdopt is omitted, fixes #843 (#847)

When not using the `--group` cmdopt (or envvar `PW_GROUP`),
pgwatch should monitor all sources by design

Author: pashagolub

.gitignore

@@ -12,6 +12,9 @@
 *.out
 *.txt
 
+# Protobuf files
+*.pb.go
+
 # Packages ouput folder
 dist
 docs/godoc

internal/reaper/reaper.go

@@ -379,7 +379,7 @@ func (r *Reaper) LoadSources() (err error) {
 		return err
 	}
 	srcs = slices.DeleteFunc(srcs, func(s sources.Source) bool {
-		return !s.IsEnabled || !s.IsDefaultGroup() && !slices.Contains(r.Sources.Groups, s.Group)
+		return !s.IsEnabled || len(r.Sources.Groups) > 0 && !s.IsDefaultGroup() && !slices.Contains(r.Sources.Groups, s.Group)
 	})
 	if newSrcs, err = srcs.ResolveDatabases(); err != nil {
 		return err

internal/reaper/reaper_test.go

@@ -77,13 +77,20 @@ func TestReaper_LoadSources(t *testing.T) {
 		source2 := sources.Source{Name: "Source 2", IsEnabled: true, Kind: sources.SourcePostgres, Group: "group1"}
 		source3 := sources.Source{Name: "Source 3", IsEnabled: true, Kind: sources.SourcePostgres, Group: "group2"}
 		source4 := sources.Source{Name: "Source 4", IsEnabled: true, Kind: sources.SourcePostgres, Group: "default"} // Default group should not filter
-		reader := &mockReader{toReturn: sources.Sources{source1, source2, source3, source4}}
-		r := NewReaper(ctx, &cmdopts.Options{SourcesReaderWriter: reader, Sources: sources.CmdOpts{Groups: []string{"group1", "group2"}}})
+		newReader := func() sources.ReaderWriter {
+			return &mockReader{toReturn: sources.Sources{source1, source2, source3, source4}}
+		}
+
+		r := NewReaper(ctx, &cmdopts.Options{SourcesReaderWriter: newReader(), Sources: sources.CmdOpts{Groups: []string{"group1", "group2"}}})
 		assert.NoError(t, r.LoadSources())
-		assert.Equal(t, 4, len(r.monitoredSources), "Expected three monitored sources after load")
+		assert.Equal(t, 4, len(r.monitoredSources), "Expected four monitored sources after load")
 
-		r.Sources.Groups = []string{"group1"}
+		r = NewReaper(ctx, &cmdopts.Options{SourcesReaderWriter: newReader(), Sources: sources.CmdOpts{Groups: []string{"group1"}}})
 		assert.NoError(t, r.LoadSources())
 		assert.Equal(t, 3, len(r.monitoredSources), "Expected three monitored sources after group filtering")
+
+		r = NewReaper(ctx, &cmdopts.Options{SourcesReaderWriter: newReader()})
+		assert.NoError(t, r.LoadSources())
+		assert.Equal(t, 4, len(r.monitoredSources), "Expected four monitored sources after resetting groups")
 	})
 }