[*] remove obsolete unreachable map (#672)

Author: pashagolub

internal/reaper/cache.go

@@ -18,9 +18,6 @@ var MonitoredDatabasesSettings = make(map[string]MonitoredDatabaseSettings)
 var MonitoredDatabasesSettingsLock = sync.RWMutex{}
 var MonitoredDatabasesSettingsGetLock = make(map[string]*sync.RWMutex) // synchronize initial PG version detection to 1 instance for each defined host
 
-var unreachableDBsLock sync.RWMutex
-var unreachableDB = make(map[string]time.Time)
-
 var lastDBSizeMB = make(map[string]int64)
 var lastDBSizeFetchTime = make(map[string]time.Time) // cached for DB_SIZE_CACHING_INTERVAL
 var lastDBSizeCheckLock sync.RWMutex

internal/reaper/database.go

@@ -891,18 +891,6 @@ func CloseResourcesForRemovedMonitoredDBs(metricsWriter sinks.Writer, currentDBs
 	}
 }
 
-func SetDBUnreachableState(dbUnique string) {
-	unreachableDBsLock.Lock()
-	unreachableDB[dbUnique] = time.Now()
-	unreachableDBsLock.Unlock()
-}
-
-func ClearDBUnreachableStateIfAny(dbUnique string) {
-	unreachableDBsLock.Lock()
-	delete(unreachableDB, dbUnique)
-	unreachableDBsLock.Unlock()
-}
-
 func SetUndersizedDBState(dbUnique string, state bool) {
 	undersizedDBsLock.Lock()
 	undersizedDBs[dbUnique] = state

internal/reaper/reaper.go

@@ -296,7 +296,6 @@ func (r *Reaper) Reap(ctx context.Context) (err error) {
 				logger.WithField("source", db).WithField("metric", metric).Info("stoppin gatherer...")
 				cancelFunc()
 				delete(cancelFuncs, dbMetric)
-				ClearDBUnreachableStateIfAny(db)
 				if err := r.SinksWriter.SyncMetric(db, metric, "remove"); err != nil {
 					logger.Error(err)
 				}
@@ -644,10 +643,6 @@ func FetchMetrics(ctx context.Context,
 				goto send_to_storageChannel
 			}
 
-			if strings.Contains(err.Error(), "connection refused") {
-				SetDBUnreachableState(msg.DBUniqueName)
-			}
-
 			log.GetLogger(ctx).
 				WithFields(map[string]any{"source": msg.DBUniqueName, "metric": msg.MetricName}).
 				WithError(err).Error("failed to fetch metrics")
@@ -656,8 +651,6 @@ func FetchMetrics(ctx context.Context,
 		}
 
 		log.GetLogger(ctx).WithFields(map[string]any{"source": msg.DBUniqueName, "metric": msg.MetricName, "rows": len(data)}).Info("measurements fetched")
-		ClearDBUnreachableStateIfAny(msg.DBUniqueName)
-
 	}
 
 	if isCacheable && opts.Metrics.InstanceLevelCacheMaxSeconds > 0 && msg.Interval.Seconds() > float64(opts.Metrics.InstanceLevelCacheMaxSeconds) {