Skip to content

Commit df9dac8

Browse files
authored
[*] add init_sql for metrics with external dependencies (#641)
Make sure all metrics have `init_sql` if they dependent on extensions or anything else not available out of the box on vanilla Postgres. Remove deprecated influx preset
1 parent 9e50529 commit df9dac8

File tree

1 file changed

+9
-38
lines changed

1 file changed

+9
-38
lines changed

internal/metrics/metrics.yaml

Lines changed: 9 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,6 @@ metrics:
322322
from
323323
get_load_average(); -- needs the plpythonu proc from "metric_fetching_helpers" folder
324324
init_sql: |-
325-
BEGIN;
326325
CREATE EXTENSION IF NOT EXISTS plpython3u;
327326
CREATE OR REPLACE FUNCTION get_load_average(OUT load_1min float, OUT load_5min float, OUT load_15min float) AS
328327
$$
@@ -332,7 +331,6 @@ metrics:
332331
$$ LANGUAGE plpython3u VOLATILE;
333332
GRANT EXECUTE ON FUNCTION get_load_average() TO pgwatch;
334333
COMMENT ON FUNCTION get_load_average() is 'created for pgwatch';
335-
COMMIT;
336334
gauges:
337335
- '*'
338336
is_instance_level: true
@@ -389,6 +387,9 @@ metrics:
389387
- '*'
390388
metric_storage_name: db_size
391389
db_stats:
390+
init_sql: |-
391+
GRANT EXECUTE ON FUNCTION pg_stat_file(text) TO pgwatch;
392+
GRANT EXECUTE ON FUNCTION pg_stat_file(text, boolean) TO pgwatch;
392393
sqls:
393394
11: |-
394395
select /* pgwatch_generated */
@@ -1308,6 +1309,7 @@ metrics:
13081309
- '*'
13091310
is_instance_level: true
13101311
reco_add_index:
1312+
init_sql: CREATE EXTENSION IF NOT EXISTS pg_qualstats;
13111313
sqls:
13121314
11: |-
13131315
/* assumes the pg_qualstats extension and superuser or select grants on pg_qualstats_indexes_ddl view */
@@ -1329,6 +1331,7 @@ metrics:
13291331
- ext_name: pg_qualstats
13301332
ext_min_version: "2.0"
13311333
reco_add_index_ext_qualstats_2.0:
1334+
init_sql: CREATE EXTENSION IF NOT EXISTS pg_qualstats;
13321335
sqls:
13331336
11: |-
13341337
/* assumes the pg_qualstats extension and superuser or select grant on pg_qualstats_index_advisor() function */
@@ -1388,6 +1391,7 @@ metrics:
13881391
tgenabled = 'D'
13891392
node_status: primary
13901393
reco_drop_index:
1394+
init_sql: CREATE EXTENSION IF NOT EXISTS pg_qualstats;
13911395
sqls:
13921396
11: |
13931397
/* assumes the pg_qualstats extension */
@@ -1864,6 +1868,7 @@ metrics:
18641868
gauges:
18651869
- '*'
18661870
stat_statements:
1871+
init_sql: CREATE EXTENSION IF NOT EXISTS pg_stat_statements;
18671872
sqls:
18681873
11: |-
18691874
WITH q_data AS (
@@ -2435,6 +2440,7 @@ metrics:
24352440
temp_blks_written DESC
24362441
LIMIT 100) a) b;
24372442
stat_statements_calls:
2443+
init_sql: CREATE EXTENSION IF NOT EXISTS pg_stat_statements;
24382444
sqls:
24392445
11: |
24402446
select /* pgwatch_generated */
@@ -2456,6 +2462,7 @@ metrics:
24562462
where
24572463
dbid = (select oid from pg_database where datname = current_database())
24582464
stat_statements_no_query_text:
2465+
init_sql: CREATE EXTENSION IF NOT EXISTS pg_stat_statements;
24592466
sqls:
24602467
11: |-
24612468
with q_data as (
@@ -4125,42 +4132,6 @@ presets:
41254132
wal: 60
41264133
wal_receiver: 120
41274134
wal_size: 120
4128-
full_influx:
4129-
description: almost all available metrics for a even deeper performance understanding
4130-
metrics:
4131-
archiver: 60
4132-
backends: 60
4133-
bgwriter: 60
4134-
checkpointer: 60
4135-
change_events: 300
4136-
cpu_load: 60
4137-
db_size: 300
4138-
db_stats: 60
4139-
index_stats: 900
4140-
kpi: 120
4141-
locks: 60
4142-
locks_mode: 60
4143-
logical_subscriptions: 120
4144-
psutil_cpu: 120
4145-
psutil_disk: 120
4146-
psutil_disk_io_total: 120
4147-
psutil_mem: 120
4148-
recommendations: 43200
4149-
replication: 120
4150-
replication_slots: 120
4151-
sequence_health: 3600
4152-
server_log_event_counts: 60
4153-
settings: 7200
4154-
sproc_stats: 180
4155-
stat_ssl: 120
4156-
stat_statements: 180
4157-
stat_statements_calls: 60
4158-
table_bloat_approx_summary_sql: 7200
4159-
table_io_stats: 600
4160-
table_stats: 300
4161-
wal: 60
4162-
wal_receiver: 120
4163-
wal_size: 120
41644135
gce:
41654136
description: similar to 'exhaustive' with stuff not accessible on GCE managed PostgreSQL engine removed
41664137
metrics:

0 commit comments

Comments
 (0)