Optimize gatherer restarts for single metric changes

[sagnik3788]

Describe the bug
currently when we change anything in the source config like name or custom_tags or add a new , reaper restart all the goroutines running those metrics

To Reproduce
start the pgwatch agent and check logs
update from source
Observe logs. it will show restarting all gatherers...

Expected behavior
for non critical changes like custom_tags , group etc existing goroutines should be undisturbed
full restart for like change in connstr

Screenshots

[sagnik3788]

If you are not working on this, could you assign it to me? @0xgouda

[0xgouda]

for non critical changes like custom_tags , group etc existing goroutines should be undisturbed

Nope, that's not a bug. If they didn't restart, the changes wouldn't get reflected in the working routines, I set it as a todo because it can be optimized (probably)

You are very much welcomed to work on optimizing it, so please do, but also note (this is not related to you specifically by any means) that from now own any PR that is noted to be entirely AI-generated won't be reviewed, as we are suffering with that.

[sagnik3788]

Nope, that's not a bug. If they didn't restart, the changes wouldn't get reflected in the working routines,

I dont get it , If i add a new single metric why we need to restart all the other which are separate ?
same for deletion

[0xgouda]

I dont get it , If i add a tag in a single metric why we need to restart all the other which are separate ? same for deletion

We don't need to, I took that simplest approach to reslove the bug back then and added this as a TODO to be optimized, and anyways its not bad to have it that way, users won't be changing their configs (and adding/deleting metrics) that frequently so its acceptable.

But if you want to optimize it go ahead.