⚰️ Fixing Deprecations

Author: nadnoslen

MODULE_REPORT.md

@@ -0,0 +1,28 @@
+## Module Report
+### Unknown Global
+
+**Global**: `Ember.Logger`
+
+**Location**: `addon/services/showdown-converter.js` at line 16
+
+```js
+    // set showdown global settings from the environment
+    if (Ember.isEmpty(config.APP.showdown)) {
+      Ember.Logger.info('The `ember-cli-marked-down` addon will use ShowdownJS defaults to create the Converters.');
+      Ember.Logger.info('If you want to customize ShowdownJS behaviour, please see the ember-cli-marked-down README: https://github.com/cybertoothca/ember-cli-marked-down#showdownjs-configuration-optional');
+      return;
+```
+
+### Unknown Global
+
+**Global**: `Ember.Logger`
+
+**Location**: `addon/services/showdown-converter.js` at line 17
+
+```js
+    if (Ember.isEmpty(config.APP.showdown)) {
+      Ember.Logger.info('The `ember-cli-marked-down` addon will use ShowdownJS defaults to create the Converters.');
+      Ember.Logger.info('If you want to customize ShowdownJS behaviour, please see the ember-cli-marked-down README: https://github.com/cybertoothca/ember-cli-marked-down#showdownjs-configuration-optional');
+      return;
+    }
+```

addon/components/set-links-target.js

@@ -1,48 +1,57 @@
-import Ember from 'ember';
-import startsWith from 'lodash.startswith';
-import layout from '../templates/components/set-links-target';
+import $ from "jquery";
+import startsWith from "lodash.startswith";
 
-export default Ember.Component.extend({
-  classNames: ['set-links-target'],
+import Component from "@ember/component";
+import { computed } from "@ember/object";
+import { isEmpty, isPresent } from "@ember/utils";
+
+import layout from "../templates/components/set-links-target";
+
+export default Component.extend({
+  classNames: ["set-links-target"],
   /**
    * When true (DEFAULT), any links found in the yield with the same host as `document.location.origin` will not have their
    * `target` attribute modified.
    * When false, every link that is found without a target will be modified.
    */
-  'excludeSelfLinks?': true,
+  "excludeSelfLinks?": true,
   layout,
   /**
    * Can be one of `_blank`, `_self`, `_parent`, `_top`, or a frame name.
    * @see http://www.w3schools.com/jsref/prop_anchor_target.asp
    */
-  targetValue: '_blank',
+  targetValue: "_blank",
   /**
    * Determines the `window.document.location.origin` because PhantomJS does not have a notion of the location object.
    */
-  _origin: Ember.computed(function() {
-    if (Ember.isPresent(document)) {
+  _origin: computed(function () {
+    if (isPresent(document)) {
       return document.location.origin;
     }
-    return 'http://localhost:7357';
+    return "http://localhost:7357";
   }),
   /**
    * Sets any `<a>` (link) `target` attributes to whatever we've specified in the `targetValue` property.
    */
-  _setTarget: Ember.on('didInsertElement', function() {
-    const excludeSelfLinks = this.get('excludeSelfLinks?');
-    const origin = this.get('_origin');
-    const targetValue = this.get('targetValue');
+  didInsertElement() {
+    const excludeSelfLinks = this.get("excludeSelfLinks?");
+    const origin = this.get("_origin");
+    const targetValue = this.get("targetValue");
     // for each anchor check if we should set the target
-    this.$('a').each((index, element) => {
-      const link = Ember.$(element);
+    this.$("a").each((index, element) => {
+      const link = $(element);
       // are we excluding links to self?
-      if (Ember.isPresent(link.attr('href')) && startsWith(link.attr('href'), origin) && excludeSelfLinks) {
+      if (
+        isPresent(link.attr("href")) &&
+        startsWith(link.attr("href"), origin) &&
+        excludeSelfLinks
+      ) {
         return;
       }
       // got this far, then apply a target if it hasn't already got one
-      if (Ember.isEmpty(link.attr('target'))) {
-        link.attr('target', targetValue);
+      if (isEmpty(link.attr("target"))) {
+        link.attr("target", targetValue);
       }
     });
-  })
+  },
 });

addon/helpers/marked-down.js

@@ -1,12 +1,15 @@
-import Ember from 'ember';
+import { helper as buildHelper } from '@ember/component/helper';
+import { htmlSafe } from '@ember/template';
+import EmberObject from '@ember/object';
+import { isEmpty, isBlank } from '@ember/utils';
 import showdown from 'showdown';
 
 export function markedDown(src, hash) {
-  if (Ember.isEmpty(src) || Ember.isBlank(src[0])) {
+  if (isEmpty(src) || isBlank(src[0])) {
     return '';
   }
-  const converter = new showdown.Converter(Ember.Object.create(hash));
-  return Ember.String.htmlSafe(converter.makeHtml(src[0].toString()));
+  const converter = new showdown.Converter(EmberObject.create(hash));
+  return htmlSafe(converter.makeHtml(src[0].toString()));
 }
 
-export default Ember.Helper.helper(markedDown);
+export default buildHelper(markedDown);

addon/services/showdown-converter.js

@@ -1,23 +1,28 @@
+import EmberObject from '@ember/object';
+import { isEmpty } from '@ember/utils';
+import { getOwner } from '@ember/application';
+import { on } from '@ember/object/evented';
+import Service from '@ember/service';
 import Ember from 'ember';
 import showdown from 'showdown';
 
-export default Ember.Service.extend({
+export default Service.extend({
   /**
    * When initializing the Service set all of the globals according to the values found in the `environment.js`.
    */
-  _instantiateConverter: Ember.on('init', function () {
+  _instantiateConverter: on('init', function () {
     this._setShowdownGlobals();
   }),
   _setShowdownGlobals() {
     // grab the application configuration
-    const config = Ember.getOwner(this).resolveRegistration('config:environment');
+    const config = getOwner(this).resolveRegistration('config:environment');
     // set showdown global settings from the environment
-    if (Ember.isEmpty(config.APP.showdown)) {
+    if (isEmpty(config.APP.showdown)) {
       Ember.Logger.info('The `ember-cli-marked-down` addon will use ShowdownJS defaults to create the Converters.');
       Ember.Logger.info('If you want to customize ShowdownJS behaviour, please see the ember-cli-marked-down README: https://github.com/cybertoothca/ember-cli-marked-down#showdownjs-configuration-optional');
       return;
     }
-    const showdownConfig = Ember.Object.create(config.APP.showdown);
+    const showdownConfig = EmberObject.create(config.APP.showdown);
     // setting details can be found here: https://github.com/showdownjs/showdown#valid-options
     Object.keys(showdownConfig).forEach((key) => {
       showdown.setOption(key, showdownConfig.get(key));

tests/dummy/app/routes/another-page.js

@@ -1,3 +1,3 @@
-import Ember from 'ember';
+import Route from '@ember/routing/route';
 
-export default Ember.Route.extend({});
+export default Route.extend({});

tests/dummy/app/routes/application.js

@@ -1,3 +1,3 @@
-import Ember from 'ember';
+import Route from '@ember/routing/route';
 
-export default Ember.Route.extend({});
+export default Route.extend({});

tests/dummy/app/routes/index.js

@@ -1,3 +1,3 @@
-import Ember from 'ember';
+import Route from '@ember/routing/route';
 
-export default Ember.Route.extend({});
+export default Route.extend({});

tests/unit/initializers/showdown-converter-test.js

@@ -1,13 +1,14 @@
-import Ember from 'ember';
+import Application from '@ember/application';
+import { run } from '@ember/runloop';
 import ShowdownConverterInitializer from 'dummy/initializers/showdown-converter';
 import { module, test } from 'qunit';
 
 let application;
 
 module('Unit | Initializer | showdown converter', {
   beforeEach() {
-    Ember.run(function () {
-      application = Ember.Application.create();
+    run(function () {
+      application = Application.create();
       application.deferReadiness();
     });
   }